Issue 2763813002: Ensure correctness for interleaved IndexedDB cursor iteration.

pwnall

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-21 00:02:51 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763813002/1

3 years, 9 months ago (2017-03-21 00:03:34 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 9 months ago (2017-03-21 00:54:09 UTC) #3

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/410770)

3 years, 9 months ago (2017-03-21 00:54:09 UTC) #4

pwnall

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-22 20:04:34 UTC) #5

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763813002/20001

3 years, 9 months ago (2017-03-22 20:05:21 UTC) #6

pwnall

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-22 21:25:29 UTC) #7

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763813002/40001

3 years, 9 months ago (2017-03-22 21:25:48 UTC) #8

pwnall

Description was changed from ========== LayoutTest for leveldb memory exhaustion. BUG=702787 ========== to ========== Ensure ...

3 years, 9 months ago (2017-03-22 21:28:36 UTC) #9

pwnall

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-22 21:31:12 UTC) #10

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763813002/60001

3 years, 9 months ago (2017-03-22 21:31:37 UTC) #11

pwnall

pwnall@chromium.org changed reviewers: + dmurph@chromium.org, jsbell@chromium.org

3 years, 9 months ago (2017-03-22 21:42:30 UTC) #16

pwnall

jsbell: Can you please review the test? dmurph: Can you please verify that the test ...

3 years, 9 months ago (2017-03-22 21:42:31 UTC) #17

jsbell

https://codereview.chromium.org/2763813002/diff/80001/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html File third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html (right): https://codereview.chromium.org/2763813002/diff/80001/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html#newcode1 third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html:1: <!doctype html> I don't think this is appropriate for ...

3 years, 9 months ago (2017-03-22 22:35:33 UTC) #18

dmurph

https://codereview.chromium.org/2763813002/diff/80001/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html File third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html (right): https://codereview.chromium.org/2763813002/diff/80001/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html#newcode65 third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html:65: I'm really confused about what's happening here... can we ...

3 years, 9 months ago (2017-03-22 23:34:54 UTC) #19

pwnall

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-23 02:06:30 UTC) #20

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763813002/100001

3 years, 9 months ago (2017-03-23 02:07:06 UTC) #21

pwnall

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-23 03:18:22 UTC) #23

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763813002/140001

3 years, 9 months ago (2017-03-23 03:18:42 UTC) #24

pwnall

jsbell, dmurph: Thank you very much for the thorough feedback. PTAL? https://codereview.chromium.org/2763813002/diff/80001/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html File third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html (right): ...

3 years, 9 months ago (2017-03-23 03:18:57 UTC) #25

jsbell, dmurph: Thank you very much for the thorough feedback. PTAL?

https://codereview.chromium.org/2763813002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html
(right):

https://codereview.chromium.org/2763813002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html:1:
<!doctype html>
On 2017/03/22 22:35:33, jsbell wrote:
> I don't think this is appropriate for wpt - it's not exercising the standard
in
> ways others tests don't.

I thought it would be useful to contribute this to WPT because it checks for a
possible issue in reasonable implementations, similarly to
https://github.com/w3c/web-platform-tests/blob/master/IndexedDB/name-scopes.html

Happy to move it to our LayoutTests if you still disagree.

https://codereview.chromium.org/2763813002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html:13:
// spill to a different block.
On 2017/03/22 22:35:33, jsbell wrote:
> This is a very implementation-specific assumption. I'd explicitly mention
> leveldb here so a reader doesn't go looking in the spec for "block".

I meant "block in the backend used by IndexedDB". SQLite also has a block size,
which is also 4kb by default. I tried rewording the comment. WDYT?

https://codereview.chromium.org/2763813002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html:22:
const char = String.fromCharCode(
On 2017/03/22 22:35:33, jsbell wrote:
> WDTY about using a Uint8Array() to get an exact byte size, and .fill(), so we
> don't have to guess the string encoding (i.e. will it be UTF-8 or UTF-16 on
> disk?)
> 
> Also... since it's repeated, are we going to get compression kicking in?
Should
> we use crypto.getRandomValues(), or is that overthinking it?

Done.

I didn't use crypto.getRandomValues() because I need to be able to re-generate
the block. I don't want to hang onto all the arrays in the renderer, and I like
the idea of having the test being deterministic. (well, as deterministic as an
I/O test can be)

I used a 32-bit xorshift generator instead. It's not crypto-strength, but it
should be more than enough to bypass snappy and the like.

https://codereview.chromium.org/2763813002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html:34:
const transaction = database.transaction('cache', 'readwrite');
On 2017/03/22 22:35:33, jsbell wrote:
> Can you explain/document why we're writing the objects using multiple
> transactions, and doing it with a chain of promises?
> 
> 

Done.

I don't have an explanation for the promise chain, other than I think it made it
easier for me to express the logic.

https://codereview.chromium.org/2763813002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html:49:
const cursors = new Array(cursorCount);
On 2017/03/22 22:35:33, jsbell wrote:
> I'd just use `cursors = []` - the Array constructor is scary.

Done.

https://codereview.chromium.org/2763813002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html:49:
const cursors = new Array(cursorCount);
On 2017/03/22 22:35:33, jsbell wrote:
> Also, you may as well pull this and itemIndex into the `new Promise` callback
-
> there's no need for them to be outside. Admittedly, they'll never throw, but
> it's good practice to put as much inside the callback so an exception turns
into
> a rejection.

Done.

https://codereview.chromium.org/2763813002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html:65:

On 2017/03/22 23:34:54, dmurph wrote:
> I'm really confused about what's happening here... can we distinguish the
parts
> of the method that are from the initial open, and the iteration? And then
adding
> how we create a new cursor and when we call continue... a little over my head
> right now, but maybe that's because I just came back from a run.
> 
> We have the following options / cases I think:
> 1. The docs case - create N cursors, and then call update. This should be
great
> for the pooling, as we never use the cursors again.
> 2. Exercising the pooling system case:
>   a. create N cursors
>   b. call continue
>     i. every call to continue - especially if you're going in order here - be
> the worst case for the pooling system, as we're an LRU.
>   c. call update maybe? This shouldn't hit the pooling system.
> 
> WDYT?
> 
> Either way, please split the logic up here so I know when
> 1. We've just created the cursor
> 2. We're iterating the cursor
> 3. We're creating a new cursor - and why/when we're iterating a (different?)
> cursor?

I split up the logic so it's clearer what the current test does. That blew up
the code quite a bit, though. PTAL and tell me what you think?

I didn't use update() at all, because it doesn't seem to be necessary to test
cursor restoration., and keeping track of updates would be non-trivial with this
test logic.

If you think that an update() test is necessary (I suppose it could reveal
errors in cursor eviction that wouldn't be visible in read-only transactions), I
can write a separate test.

https://codereview.chromium.org/2763813002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html:87:
const cursorCount = i;
On 2017/03/22 22:35:33, jsbell wrote:
> I don't think this extra const adds a lot here. (Also, `for(const` ... is
> supposed to work at some point.)

Done.

https://codereview.chromium.org/2763813002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html:94:
() => database);
On 2017/03/22 22:35:33, jsbell wrote:
> (rant: someday we'll be able to use async/await...)

Done.

https://codereview.chromium.org/2763813002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html:104:
database.close()
On 2017/03/22 22:35:33, jsbell wrote:
> Add a test cleanup step to delete the database? Per
> https://github.com/w3c/web-platform-tests/issues/4560
> 
> (this set of promise helpers doesn't do that automagically)

I fixed the helpers :D

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 9 months ago (2017-03-23 04:28:20 UTC) #26

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/406374)

3 years, 9 months ago (2017-03-23 04:28:21 UTC) #27

pwnall

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-23 08:47:03 UTC) #28

pwnall

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-23 08:47:38 UTC) #29

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763813002/180001

3 years, 9 months ago (2017-03-23 08:47:52 UTC) #30

pwnall

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-23 08:50:16 UTC) #32

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763813002/200001

3 years, 9 months ago (2017-03-23 08:50:35 UTC) #33

pwnall

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-23 08:51:47 UTC) #34

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763813002/200002

3 years, 9 months ago (2017-03-23 08:52:01 UTC) #35

pwnall

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-23 08:53:33 UTC) #36

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763813002/220001

3 years, 9 months ago (2017-03-23 08:53:47 UTC) #37

pwnall

I think the timeouts are because of some assert that's super-linear in database size, transaction ...

3 years, 9 months ago (2017-03-23 08:55:47 UTC) #38

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 9 months ago (2017-03-23 09:53:29 UTC) #39

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

3 years, 9 months ago (2017-03-23 09:53:30 UTC) #40

pwnall

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-23 18:16:00 UTC) #41

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763813002/240001

3 years, 9 months ago (2017-03-23 18:16:57 UTC) #42

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 9 months ago (2017-03-23 18:34:04 UTC) #43

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/406880)

3 years, 9 months ago (2017-03-23 18:34:05 UTC) #44

dmurph

I wish we didn't have to change quota settings, but I guess there's no way ...

3 years, 9 months ago (2017-03-23 21:10:52 UTC) #45

jsbell

https://codereview.chromium.org/2763813002/diff/240001/content/shell/browser/layout_test/layout_test_content_browser_client.cc File content/shell/browser/layout_test/layout_test_content_browser_client.cc (right): https://codereview.chromium.org/2763813002/diff/240001/content/shell/browser/layout_test/layout_test_content_browser_client.cc#newcode135 content/shell/browser/layout_test/layout_test_content_browser_client.cc:135: callback.Run(storage::GetHardCodedSettings(1024 * 1024 * 1024)); Might want to add ...

3 years, 9 months ago (2017-03-23 21:20:01 UTC) #46

pwnall

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-23 21:42:03 UTC) #47

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763813002/260001

3 years, 9 months ago (2017-03-23 21:42:56 UTC) #48

pwnall

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-23 21:44:02 UTC) #49

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763813002/280001

3 years, 9 months ago (2017-03-23 21:44:40 UTC) #51

pwnall

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-23 22:07:10 UTC) #52

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763813002/300001

3 years, 9 months ago (2017-03-23 22:08:01 UTC) #53

pwnall

dmurph, jsbell: Thank you very much for the feedback! jsbell: PTAL? https://codereview.chromium.org/2763813002/diff/240001/content/shell/browser/layout_test/layout_test_content_browser_client.cc File content/shell/browser/layout_test/layout_test_content_browser_client.cc (right): ...

3 years, 9 months ago (2017-03-23 22:08:27 UTC) #54

dmurph, jsbell: Thank you very much for the feedback!

jsbell: PTAL?

https://codereview.chromium.org/2763813002/diff/240001/content/shell/browser/...
File content/shell/browser/layout_test/layout_test_content_browser_client.cc
(right):

https://codereview.chromium.org/2763813002/diff/240001/content/shell/browser/...
content/shell/browser/layout_test/layout_test_content_browser_client.cc:135:
callback.Run(storage::GetHardCodedSettings(1024 * 1024 * 1024));
On 2017/03/23 21:20:01, jsbell wrote:
> Might want to add a comment, e.g.
> 
> "1GB to allow plenty of headroom for tests that exercise concurrent writes
> without hitting quota errors."
> 
> 

Done.

This code appears to have been introduced in http://crrev.com/1782053004 and I
couldn't quickly find a justification for the old 5MB quota.

https://codereview.chromium.org/2763813002/diff/240001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html
(right):

https://codereview.chromium.org/2763813002/diff/240001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html:71:
transaction.onerror = () => { reject(transaction.error); };
On 2017/03/23 21:20:01, jsbell wrote:
> transaction.error won't be set to anything here since the transaction hasn't
> failed when the 'error' event is bubbling from the request
> 
> I'd just drop the transaction.onerror handler (since the tx will abort if any
> request fails)
> 

Done.

https://codereview.chromium.org/2763813002/diff/240001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html:89:
const requests = [];
On 2017/03/23 21:10:52, dmurph wrote:
> Can you add a comment like the following:
> // Request received from openCursor, which is called both on cursor creation
and
> iteration.

Done.

https://codereview.chromium.org/2763813002/diff/240001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html:166:
return interleaveCursors(testCase, store, cursorCount).then(
On 2017/03/23 21:20:01, jsbell wrote:
> This return means the transaction.onXXX below won't run.

Done.
Durr! Thanks for catching that!

https://codereview.chromium.org/2763813002/diff/240001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html:169:
transaction.onerror = () => { reject(transaction.error); };
On 2017/03/23 21:20:01, jsbell wrote:
> Same as above - don't bother with transaction.onerror.

Done.

pwnall

https://codereview.chromium.org/2763813002/diff/80001/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html File third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html (right): https://codereview.chromium.org/2763813002/diff/80001/third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html#newcode94 third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interleaved-cursors.html:94: () => database); On 2017/03/23 03:18:57, pwnall wrote: > ...

3 years, 9 months ago (2017-03-23 22:09:30 UTC) #55

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 9 months ago (2017-03-23 22:20:50 UTC) #56

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/346965) linux_chromium_chromeos_rel_ng on ...

3 years, 9 months ago (2017-03-23 22:20:51 UTC) #57

pwnall

The patchset sent to the CQ was uploaded after l-g-t-m from dmurph@chromium.org Link to the ...

3 years, 9 months ago (2017-03-24 20:48:34 UTC) #60

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763813002/300001

3 years, 9 months ago (2017-03-24 20:49:25 UTC) #61

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 9 months ago (2017-03-24 20:59:30 UTC) #62

commit-bot: I haz the power

Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/394403)

3 years, 9 months ago (2017-03-24 20:59:32 UTC) #63

pwnall

pwnall@chromium.org changed reviewers: + dgozman@chromium.org

3 years, 9 months ago (2017-03-24 21:21:26 UTC) #64

pwnall

dgozman@chromium.org: Can you please review changes in content/shell/browser/layout_test/layout_test_content_browser_client.cc?

3 years, 9 months ago (2017-03-24 21:21:27 UTC) #65

pwnall

On 2017/03/24 22:47:41, dgozman wrote: > lgtm Thank you very much for the quick turnaround!

3 years, 9 months ago (2017-03-24 22:52:50 UTC) #68

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763813002/300001

3 years, 9 months ago (2017-03-24 22:53:00 UTC) #69

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 9 months ago (2017-03-24 23:18:57 UTC) #70

commit-bot: I haz the power

Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/391474)

3 years, 9 months ago (2017-03-24 23:18:58 UTC) #71

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763813002/300001

3 years, 9 months ago (2017-03-24 23:48:02 UTC) #73

commit-bot: I haz the power

CQ is committing da patch. Bot data: {"patchset_id": 300001, "attempt_start_ts": 1490399251244190, "parent_rev": "ceec5078d982398f334025bb4c2bb5c01d39d42c", "commit_rev": "9de6f24edfb54f9afd3d2dee474a2602585f68dc"}

3 years, 9 months ago (2017-03-25 01:12:09 UTC) #74

commit-bot: I haz the power

Description was changed from ========== Ensure correctness for interleaved IndexedDB cursor iteration. BUG=702787 ========== to ...

3 years, 9 months ago (2017-03-25 01:12:55 UTC) #75

commit-bot: I haz the power

3 years, 9 months ago (2017-03-25 01:12:56 UTC) #76

Message was sent while issue was closed.

Committed patchset #10 (id:300001) as
https://chromium.googlesource.com/chromium/src/+/9de6f24edfb54f9afd3d2dee474a...

Issue 2763813002: Ensure correctness for interleaved IndexedDB cursor iteration. (Closed)

Description

Patch Set 1 : Fix WPT version. #

Patch Set 2 : Addressed feedback. #

Patch Set 3 : Removed n=500 test to avoid timeout. #

Patch Set 4 : n=50 smaller constants #

Patch Set 5 : n=100 smaller constants #

Patch Set 6 : n=50 larger constants #

Patch Set 7 : n=20 larger constants #

Patch Set 8 : Relax quota restriction for the test to pass. #

Patch Set 9 : Addressed feedback. #

Patch Set 10 : Added comment showing the interleaving sequence used in this test. #

Messages