BrowserAccessibility should own a AXPlatformNode.

BrowserAccessibility should own a AXPlatformNode.

As part of the refacting of BrowserAccessibility, BrowserAccessibility will
create and own a AXPlatformNode.  BrowserAccessibility will forward
IAccessible* and related calls to the AXPlatformNode.

This change simple creates the object and does nothing with it.

BUG=703369
Review-Url: https://codereview.chromium.org/2763803002
Cr-Commit-Position: refs/heads/master@{#460289}
Committed: https://chromium.googlesource.com/chromium/src/+/5ec1039bc225dfb4221c0c5f387a37cd87fc33a1

[dougt, 2017-03-20 23:50:10]

dougt@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2017-03-21 16:45:00]

lgtm

https://codereview.chromium.org/2763803002/diff/1/content/browser/accessibili...
File content/browser/accessibility/browser_accessibility.h (right):

https://codereview.chromium.org/2763803002/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility.h:396: // The ui platform
backend
nit: Make comments full sentences, end with a period.

I'd make this comment a bit more detailed so it's more clear what we're
doing here during the transition period. Something like:

// The platform-specific object that implements the accessibility APIs for this
node.
// Currently some of the platform-specific code is implemented by subclasses of
// BrowserAccessibility and some by |platform_node_|, but eventually we want all
// of that code to be in AXPlatformNode.  http://crbug.com/xxxxxx

[dougt, 2017-03-24 19:28:47]

The CQ bit was checked by dougt@chromium.org

[dougt, 2017-03-24 19:28:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2763803002/#ps20001
(title: "comment updated")

[commit-bot: I haz the power, 2017-03-24 19:29:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 19:39:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 19:39:59]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dougt, 2017-03-24 22:12:57]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 22:13:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 22:27:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 22:27:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dougt, 2017-03-25 07:48:44]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 07:48:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 08:01:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 08:01:44]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[dougt, 2017-03-25 14:52:48]

Patchset #4 (id:60001) has been deleted

[dougt, 2017-03-25 14:53:30]

Patchset #3 (id:40001) has been deleted

[dougt, 2017-03-25 14:56:25]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 14:56:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 15:06:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 15:06:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dougt, 2017-03-25 16:55:25]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-25 16:55:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 17:07:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 17:07:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dougt, 2017-03-25 18:29:17]

Patchset #3 (id:80001) has been deleted

[dougt, 2017-03-26 04:55:59]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-26 04:56:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-26 05:10:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-26 05:10:54]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[dougt, 2017-03-26 06:08:15]

Patchset #3 (id:100001) has been deleted

[dougt, 2017-03-28 15:39:06]

The CQ bit was checked by dougt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 15:39:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougt, 2017-03-28 16:28:35]

dmazzoni, ptal.

AXPlatformNode::Create() doesn't exists on some systems (f.e, Android). In this
CL, I am just #ifdef'ing the create in BrowserAccessibility.  I think we
probably want to stub out the ::Create() method to return null for platforms
which don't have a platform node.

[dmazzoni, 2017-03-28 17:11:38]

lgtm

[commit-bot: I haz the power, 2017-03-28 17:29:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 17:29:28]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dougt, 2017-03-28 22:12:48]

The CQ bit was checked by dougt@chromium.org

[commit-bot: I haz the power, 2017-03-28 22:13:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 01:41:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:41:58]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dougt, 2017-03-29 03:50:36]

The CQ bit was checked by dougt@chromium.org

[commit-bot: I haz the power, 2017-03-29 03:51:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 05:40:14]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1490759436937970,
"parent_rev": "070c8ffb44d04075bd7400691a2325cb6233558a", "commit_rev":
"5ec1039bc225dfb4221c0c5f387a37cd87fc33a1"}

[commit-bot: I haz the power, 2017-03-29 05:40:57]

Description was changed from

==========
BrowserAccessibility should own a AXPlatformNode.

As part of the refacting of BrowserAccessibility, BrowserAccessibility will
create and own a AXPlatformNode.  BrowserAccessibility will forward
IAccessible* and related calls to the AXPlatformNode.

This change simple creates the object and does nothing with it.

BUG=703369
==========

to

==========
BrowserAccessibility should own a AXPlatformNode.

As part of the refacting of BrowserAccessibility, BrowserAccessibility will
create and own a AXPlatformNode.  BrowserAccessibility will forward
IAccessible* and related calls to the AXPlatformNode.

This change simple creates the object and does nothing with it.

BUG=703369

Review-Url: https://codereview.chromium.org/2763803002
Cr-Commit-Position: refs/heads/master@{#460289}
Committed:
https://chromium.googlesource.com/chromium/src/+/5ec1039bc225dfb4221c0c5f387a...
==========

[commit-bot: I haz the power, 2017-03-29 05:41:00]

Committed patchset #3 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/5ec1039bc225dfb4221c0c5f387a...