Chromium Code Reviews
Help | Chromium Project | Sign in
(66)

Issue 2763753003: [Merge To M58]Fix Default icon issue when cached icon file is corrupted. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 days, 16 hours ago by lgcheng
Modified:
2 days, 16 hours ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, Matt Giuca
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge To M58]Fix Default icon issue when cached icon file is corrupted. Some crahes lead to app cached icon file corruption. Re send icon request to ARC if bad icon is observed. Limit icon request to once per app per scale per user session. Bug=701979 Test=Unit test added. Test=Manual test. Manual corrupted cached icon. See icon restored. TBR=lhchavez@chromium.org, xiyuan@chromium.org Review-Url: https://codereview.chromium.org/2749973002 Cr-Commit-Position: refs/heads/master@{#457294} (cherry picked from commit f24408d3df3bf74f497111dd551d26a7509a07f4) Review-Url: https://codereview.chromium.org/2763753003 . Cr-Commit-Position: refs/branch-heads/3029@{#316} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/61676170d0826acfb754e8f434ef79fe909e271a

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -35 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_icon.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_icon.cc View 8 chunks +21 lines, -13 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.h View 5 chunks +27 lines, -9 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 6 chunks +36 lines, -9 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 5 chunks +72 lines, -3 lines 0 comments Download
M components/arc/test/fake_app_instance.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/arc/test/fake_app_instance.cc View 1 chunk +6 lines, -0 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 2 (1 generated)
lgcheng
2 days, 16 hours ago (2017-03-20 23:30:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
61676170d0826acfb754e8f434ef79fe909e271a (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62