Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 2763753002: gpu: Add callback for yielding command buffer execution. (Closed)

Created:
3 years, 9 months ago by sunnyps
Modified:
3 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Add callback for pausing command buffer execution. CommandExecutor can take a PauseExectionCallback to pause command execution. This is where the PreemptionFlag is hooked into and where the scheduler will too. R=piman@chromium.org BUG=514813 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2763753002 Cr-Commit-Position: refs/heads/master@{#460479} Committed: https://chromium.googlesource.com/chromium/src/+/0559d3c6822220e0e5d4e1b1e88d865fbb808ba1

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rename to pause execution callback #

Patch Set 4 : no need to !!pause #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -56 lines) Patch
M gpu/command_buffer/service/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/command_executor.h View 1 2 6 chunks +8 lines, -28 lines 0 comments Download
M gpu/command_buffer/service/command_executor.cc View 1 2 3 3 chunks +14 lines, -16 lines 0 comments Download
A gpu/command_buffer/service/preemption_flag.h View 1 chunk +33 lines, -0 lines 0 comments Download
M gpu/ipc/service/gpu_channel.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/gpu_channel_manager.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/service/gpu_command_buffer_stub.h View 1 3 chunks +6 lines, -10 lines 0 comments Download
M gpu/ipc/service/gpu_command_buffer_stub.cc View 1 2 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 24 (15 generated)
sunnyps
ptal
3 years, 9 months ago (2017-03-20 21:44:45 UTC) #4
piman
lgtm
3 years, 9 months ago (2017-03-21 00:11:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763753002/1
3 years, 9 months ago (2017-03-21 00:21:17 UTC) #9
sunnyps
I renamed the callback from TryYieldCallback to PauseExectionCallback. I'll land this now, please consider last ...
3 years, 8 months ago (2017-03-29 01:24:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763753002/60001
3 years, 8 months ago (2017-03-29 01:25:20 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 8 months ago (2017-03-29 03:27:18 UTC) #18
piman
lgtm
3 years, 8 months ago (2017-03-29 17:35:22 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763753002/60001
3 years, 8 months ago (2017-03-29 17:57:04 UTC) #21
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 19:09:10 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0559d3c6822220e0e5d4e1b1e88d...

Powered by Google App Engine
This is Rietveld 408576698