Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2763723002: Record the type of controls used for video persistence. (Closed)

Created:
3 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 9 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Record the type of controls used for video persistence. BUG=703267 R=zqzhang@chromium.org Review-Url: https://codereview.chromium.org/2763723002 Cr-Commit-Position: refs/heads/master@{#458387} Committed: https://chromium.googlesource.com/chromium/src/+/9bab651a8a170a6016af11dc0ee4f6407456fcb9

Patch Set 1 #

Total comments: 5

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 3 chunks +19 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
mlamouri (slow - plz ping)
+isherman@ for histograms.xml PTAL :)
3 years, 9 months ago (2017-03-20 18:23:44 UTC) #4
Ilya Sherman
Metrics LGTM % nits: https://codereview.chromium.org/2763723002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/2763723002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp#newcode147 third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:147: VideoPersistenceControlsTypeMax Optional nit: Typically, this ...
3 years, 9 months ago (2017-03-20 19:08:40 UTC) #5
Zhiqiang Zhang (Slow)
lgtm w/ nits https://codereview.chromium.org/2763723002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/2763723002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp#newcode147 third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:147: VideoPersistenceControlsTypeMax On 2017/03/20 at 19:08:39, Ilya ...
3 years, 9 months ago (2017-03-20 21:29:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763723002/20001
3 years, 9 months ago (2017-03-21 11:44:56 UTC) #11
mlamouri (slow - plz ping)
https://codereview.chromium.org/2763723002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/2763723002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp#newcode147 third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:147: VideoPersistenceControlsTypeMax On 2017/03/20 at 21:29:15, Zhiqiang Zhang wrote: > ...
3 years, 9 months ago (2017-03-21 12:01:21 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 13:23:53 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9bab651a8a170a6016af11dc0ee4...

Powered by Google App Engine
This is Rietveld 408576698