third_party/WebKit/Source/core/html/HTMLTableElement.cpp - Issue 2763663002: Add counters for non-standard background presentation attributes on table

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTableElement.cpp

Issue 2763663002: Add counters for non-standard background presentation attributes on table (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLTableElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTableElement.cpp b/third_party/WebKit/Source/core/html/HTMLTableElement.cpp

index 6d507ba3f0712a285d36db17bfa20c961dd39415..fa9770af711c2476bb05cd0cfdd0eec908c8ba84 100644

--- a/third_party/WebKit/Source/core/html/HTMLTableElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTableElement.cpp

@@ -38,6 +38,7 @@

#include "core/dom/ExceptionCode.h"

#include "core/dom/NodeListsNodeData.h"

#include "core/dom/StyleChangeReason.h"

+#include "core/frame/UseCounter.h"

#include "core/html/HTMLTableCaptionElement.h"

#include "core/html/HTMLTableCellElement.h"

#include "core/html/HTMLTableRowElement.h"

@@ -316,6 +317,9 @@ void HTMLTableElement::collectStyleForPresentationAttribute(

} else if (name == backgroundAttr) {

String url = stripLeadingAndTrailingHTMLSpaces(value);

if (!url.isEmpty()) {

+ UseCounter::count(

+ document(),

+ UseCounter::HTMLTableElementPresentationAttributeBackground);

CSSImageValue* imageValue =

CSSImageValue::create(url, document().completeURL(url));

imageValue->setReferrer(Referrer(document().outgoingReferrer(),