Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1227)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLTableElement.cpp

Issue 2763663002: Add counters for non-standard background presentation attributes on table (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2010, 2011 Apple Inc. All rights 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2010, 2011 Apple Inc. All rights
8 * reserved. 8 * reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 20 matching lines...) Expand all
31 #include "core/HTMLNames.h" 31 #include "core/HTMLNames.h"
32 #include "core/css/CSSIdentifierValue.h" 32 #include "core/css/CSSIdentifierValue.h"
33 #include "core/css/CSSImageValue.h" 33 #include "core/css/CSSImageValue.h"
34 #include "core/css/CSSInheritedValue.h" 34 #include "core/css/CSSInheritedValue.h"
35 #include "core/css/StylePropertySet.h" 35 #include "core/css/StylePropertySet.h"
36 #include "core/dom/Attribute.h" 36 #include "core/dom/Attribute.h"
37 #include "core/dom/ElementTraversal.h" 37 #include "core/dom/ElementTraversal.h"
38 #include "core/dom/ExceptionCode.h" 38 #include "core/dom/ExceptionCode.h"
39 #include "core/dom/NodeListsNodeData.h" 39 #include "core/dom/NodeListsNodeData.h"
40 #include "core/dom/StyleChangeReason.h" 40 #include "core/dom/StyleChangeReason.h"
41 #include "core/frame/UseCounter.h"
41 #include "core/html/HTMLTableCaptionElement.h" 42 #include "core/html/HTMLTableCaptionElement.h"
42 #include "core/html/HTMLTableCellElement.h" 43 #include "core/html/HTMLTableCellElement.h"
43 #include "core/html/HTMLTableRowElement.h" 44 #include "core/html/HTMLTableRowElement.h"
44 #include "core/html/HTMLTableRowsCollection.h" 45 #include "core/html/HTMLTableRowsCollection.h"
45 #include "core/html/HTMLTableSectionElement.h" 46 #include "core/html/HTMLTableSectionElement.h"
46 #include "core/html/parser/HTMLParserIdioms.h" 47 #include "core/html/parser/HTMLParserIdioms.h"
47 #include "platform/weborigin/Referrer.h" 48 #include "platform/weborigin/Referrer.h"
48 #include "wtf/StdLibExtras.h" 49 #include "wtf/StdLibExtras.h"
49 50
50 namespace blink { 51 namespace blink {
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 style, CSSPropertyBorderWidth, parseBorderWidthAttribute(value), 310 style, CSSPropertyBorderWidth, parseBorderWidthAttribute(value),
310 CSSPrimitiveValue::UnitType::Pixels); 311 CSSPrimitiveValue::UnitType::Pixels);
311 } else if (name == bordercolorAttr) { 312 } else if (name == bordercolorAttr) {
312 if (!value.isEmpty()) 313 if (!value.isEmpty())
313 addHTMLColorToStyle(style, CSSPropertyBorderColor, value); 314 addHTMLColorToStyle(style, CSSPropertyBorderColor, value);
314 } else if (name == bgcolorAttr) { 315 } else if (name == bgcolorAttr) {
315 addHTMLColorToStyle(style, CSSPropertyBackgroundColor, value); 316 addHTMLColorToStyle(style, CSSPropertyBackgroundColor, value);
316 } else if (name == backgroundAttr) { 317 } else if (name == backgroundAttr) {
317 String url = stripLeadingAndTrailingHTMLSpaces(value); 318 String url = stripLeadingAndTrailingHTMLSpaces(value);
318 if (!url.isEmpty()) { 319 if (!url.isEmpty()) {
320 UseCounter::count(
321 document(),
322 UseCounter::HTMLTableElementPresentationAttributeBackground);
319 CSSImageValue* imageValue = 323 CSSImageValue* imageValue =
320 CSSImageValue::create(url, document().completeURL(url)); 324 CSSImageValue::create(url, document().completeURL(url));
321 imageValue->setReferrer(Referrer(document().outgoingReferrer(), 325 imageValue->setReferrer(Referrer(document().outgoingReferrer(),
322 document().getReferrerPolicy())); 326 document().getReferrerPolicy()));
323 style->setProperty(CSSProperty(CSSPropertyBackgroundImage, *imageValue)); 327 style->setProperty(CSSProperty(CSSPropertyBackgroundImage, *imageValue));
324 } 328 }
325 } else if (name == valignAttr) { 329 } else if (name == valignAttr) {
326 if (!value.isEmpty()) 330 if (!value.isEmpty())
327 addPropertyToPresentationAttributeStyle(style, CSSPropertyVerticalAlign, 331 addPropertyToPresentationAttributeStyle(style, CSSPropertyVerticalAlign,
328 value); 332 value);
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
606 const AtomicString& HTMLTableElement::summary() const { 610 const AtomicString& HTMLTableElement::summary() const {
607 return getAttribute(summaryAttr); 611 return getAttribute(summaryAttr);
608 } 612 }
609 613
610 DEFINE_TRACE(HTMLTableElement) { 614 DEFINE_TRACE(HTMLTableElement) {
611 visitor->trace(m_sharedCellStyle); 615 visitor->trace(m_sharedCellStyle);
612 HTMLElement::trace(visitor); 616 HTMLElement::trace(visitor);
613 } 617 }
614 618
615 } // namespace blink 619 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | third_party/WebKit/Source/core/html/HTMLTablePartElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698