Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2763603003: Remove unnecessary include from SVGInlineTextBoxPainter.cpp (Closed)

Created:
3 years, 9 months ago by rlanday
Modified:
3 years, 8 months ago
Reviewers:
chrishtr, Stephen White
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, Xiaocheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary include from SVGInlineTextBoxPainter.cpp This file unnecessarily includes RenderedDocumentMarker.h. Pointed out in code review for another CL: https://codereview.chromium.org/2723663002/diff/140001/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp#oldcode9 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2763603003 Cr-Commit-Position: refs/heads/master@{#461545} Committed: https://chromium.googlesource.com/chromium/src/+/8054305d4a8aa57e06ef3e5012bf985305bc364d

Patch Set 1 #

Patch Set 2 : Rebase into a stack of dependent diffs so another CL can use this (no actual changes) #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Remove dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 43 (32 generated)
rlanday
3 years, 9 months ago (2017-03-20 20:54:53 UTC) #6
Stephen White
LGTM
3 years, 8 months ago (2017-03-30 21:12:39 UTC) #21
commit-bot: I haz the power
This CL has an open dependency (Issue 2784753002 Patch 60001). Please resolve the dependency and ...
3 years, 8 months ago (2017-03-30 21:14:53 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763603003/80001
3 years, 8 months ago (2017-03-30 23:14:23 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/412245)
3 years, 8 months ago (2017-03-31 01:34:15 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763603003/80001
3 years, 8 months ago (2017-03-31 18:23:43 UTC) #32
commit-bot: I haz the power
CQ experienced an internal error when committing your CL and the maintainers were notified. Sorry ...
3 years, 8 months ago (2017-03-31 18:32:38 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763603003/80001
3 years, 8 months ago (2017-03-31 19:13:53 UTC) #36
commit-bot: I haz the power
CQ experienced an internal error when committing your CL and the maintainers were notified. Sorry ...
3 years, 8 months ago (2017-03-31 19:18:51 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763603003/80001
3 years, 8 months ago (2017-04-03 17:34:36 UTC) #40
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 21:28:16 UTC) #43
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/8054305d4a8aa57e06ef3e5012bf...

Powered by Google App Engine
This is Rietveld 408576698