|
|
DescriptionRemove unnecessary include from SVGInlineTextBoxPainter.cpp
This file unnecessarily includes RenderedDocumentMarker.h.
Pointed out in code review for another CL:
https://codereview.chromium.org/2723663002/diff/140001/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp#oldcode9
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2763603003
Cr-Commit-Position: refs/heads/master@{#461545}
Committed: https://chromium.googlesource.com/chromium/src/+/8054305d4a8aa57e06ef3e5012bf985305bc364d
Patch Set 1 #Patch Set 2 : Rebase into a stack of dependent diffs so another CL can use this (no actual changes) #Patch Set 3 : Rebase #Patch Set 4 : Rebase #Patch Set 5 : Remove dependency #
Messages
Total messages: 43 (32 generated)
Description was changed from ========== Remove unnecessary include from SVGInlineTextBoxPainter.cpp This file unnecessarily includes RenderedDocumentMarker.h. Pointed out in code review for another CL: https://codereview.chromium.org/2723663002/diff/140001/third_party/WebKit/Sou... ========== to ========== Remove unnecessary include from SVGInlineTextBoxPainter.cpp This file unnecessarily includes RenderedDocumentMarker.h. Pointed out in code review for another CL: https://codereview.chromium.org/2723663002/diff/140001/third_party/WebKit/Sou... CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
rlanday@chromium.org changed reviewers: + senorblanco@chromium.org
rlanday@chromium.org changed required reviewers: + senorblanco@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rlanday@chromium.org changed reviewers: + chrishtr@chromium.org
rlanday@chromium.org changed required reviewers: - senorblanco@chromium.org
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity)
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rlanday@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was unchecked by rlanday@chromium.org
The CQ bit was checked by rlanday@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2784753002 Patch 60001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by rlanday@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from senorblanco@chromium.org Link to the patchset: https://codereview.chromium.org/2763603003/#ps80001 (title: "Remove dependency")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by rlanday@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CQ experienced an internal error when committing your CL and the maintainers were notified. Sorry for the inconvenience.
The CQ bit was checked by rlanday@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CQ experienced an internal error when committing your CL and the maintainers were notified. Sorry for the inconvenience.
The CQ bit was checked by rlanday@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491240830124440, "parent_rev": "a64e5348bede993ba2f5a36c656d7aebb9d9059d", "commit_rev": "8054305d4a8aa57e06ef3e5012bf985305bc364d"}
Message was sent while issue was closed.
Description was changed from ========== Remove unnecessary include from SVGInlineTextBoxPainter.cpp This file unnecessarily includes RenderedDocumentMarker.h. Pointed out in code review for another CL: https://codereview.chromium.org/2723663002/diff/140001/third_party/WebKit/Sou... CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Remove unnecessary include from SVGInlineTextBoxPainter.cpp This file unnecessarily includes RenderedDocumentMarker.h. Pointed out in code review for another CL: https://codereview.chromium.org/2723663002/diff/140001/third_party/WebKit/Sou... CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2763603003 Cr-Commit-Position: refs/heads/master@{#461545} Committed: https://chromium.googlesource.com/chromium/src/+/8054305d4a8aa57e06ef3e5012bf... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/8054305d4a8aa57e06ef3e5012bf... |