Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2763573003: Accessibility: Add gn file to build colorenhancer (Closed)

Created:
3 years, 9 months ago by Peter Wen
Modified:
3 years, 9 months ago
Reviewers:
dmazzoni, agrieve
CC:
chromium-reviews, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Accessibility: Add gn file to build colorenhancer Initial migration of the old accessibility_extensions.gyp file which was removed during the gyp purge. Starting with the colorenhancer extension. BUG=701521 Review-Url: https://codereview.chromium.org/2763573003 Cr-Commit-Position: refs/heads/master@{#458230} Committed: https://chromium.googlesource.com/chromium/src/+/2c84eb657463e156ccd0937d55d080194d0a94e6

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix per review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -3 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A ui/accessibility/extensions/BUILD.gn View 1 1 chunk +106 lines, -0 lines 0 comments Download
D ui/accessibility/extensions/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Peter Wen
PTAL +agrieve@ for BUILD.gn OWNERS My first new BUILD.gn file, so I'm sure I'm doing ...
3 years, 9 months ago (2017-03-20 20:14:28 UTC) #2
agrieve
lgtm https://codereview.chromium.org/2763573003/diff/1/ui/accessibility/extensions/BUILD.gn File ui/accessibility/extensions/BUILD.gn (right): https://codereview.chromium.org/2763573003/diff/1/ui/accessibility/extensions/BUILD.gn#newcode1 ui/accessibility/extensions/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All rights ...
3 years, 9 months ago (2017-03-20 20:29:29 UTC) #3
dmazzoni
lgtm https://codereview.chromium.org/2763573003/diff/1/ui/accessibility/extensions/BUILD.gn File ui/accessibility/extensions/BUILD.gn (right): https://codereview.chromium.org/2763573003/diff/1/ui/accessibility/extensions/BUILD.gn#newcode1 ui/accessibility/extensions/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All rights ...
3 years, 9 months ago (2017-03-20 20:29:38 UTC) #4
Peter Wen
Thanks for the quick review! Same comments, haha. zip was from when I tried to ...
3 years, 9 months ago (2017-03-20 20:33:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763573003/20001
3 years, 9 months ago (2017-03-20 20:34:26 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 23:22:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2c84eb657463e156ccd0937d55d0...

Powered by Google App Engine
This is Rietveld 408576698