Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2763563003: [DevTools] Update SecurityDetails in Security panel if State changes (Closed)

Created:
3 years, 9 months ago by elawrence
Modified:
3 years, 9 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Update SecurityDetails in Security panel if State changes When the SecurityState for an origin changes, update the Security Details for that origin as well. This mitigates scenarios where the Details may not have been available initially (e.g. an image pulled from the MemoryCache without the Developer Tools loaded will not have any SecurityDetails recorded. BUG=702001 TEST=blink_layouttests security-details-updated-with-security-state Review-Url: https://codereview.chromium.org/2763563003 Cr-Commit-Position: refs/heads/master@{#458562} Committed: https://chromium.googlesource.com/chromium/src/+/3ef0a6666394621ad4874522b05ac00dce9342fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/inspector/security/security-details-updated-with-security-state.html View 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/security/security-details-updated-with-security-state-expected.txt View 1 chunk +136 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
elawrence
PTAL? This is another case where the Security panel is improved by updating when new ...
3 years, 9 months ago (2017-03-20 19:10:51 UTC) #5
lushnikov
lgtm
3 years, 9 months ago (2017-03-21 18:11:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763563003/1
3 years, 9 months ago (2017-03-21 18:48:06 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 21:46:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3ef0a6666394621ad4874522b05a...

Powered by Google App Engine
This is Rietveld 408576698