Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2763543003: [dart:io][windows] Don't enable ENABLE_VIRTUAL_TERMINAL_INPUT (Closed)

Created:
3 years, 9 months ago by zra
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, goderbauer
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[dart:io][windows] Don't enable ENABLE_VIRTUAL_TERMINAL_INPUT fixes #29104 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/0140775f90ef35718b6474e0f9a909d4df1f470e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M runtime/bin/platform_win.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zra
3 years, 9 months ago (2017-03-20 20:11:36 UTC) #2
Florian Schneider
lgtm
3 years, 9 months ago (2017-03-20 20:17:37 UTC) #3
zra
Committed patchset #1 (id:1) manually as 0140775f90ef35718b6474e0f9a909d4df1f470e (presubmit successful).
3 years, 9 months ago (2017-03-20 20:35:30 UTC) #5
goderbauer
Does this require changes to Stdin.supportsAnsiEscapes?
3 years, 9 months ago (2017-03-20 20:37:07 UTC) #7
zra
3 years, 9 months ago (2017-03-20 20:40:44 UTC) #8
Message was sent while issue was closed.
On 2017/03/20 20:37:07, goderbauer wrote:
> Does this require changes to Stdin.supportsAnsiEscapes?

It will now always be false on Windows.

Powered by Google App Engine
This is Rietveld 408576698