Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: runtime/bin/platform_win.cc

Issue 2763543003: [dart:io][windows] Don't enable ENABLE_VIRTUAL_TERMINAL_INPUT (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/platform_win.cc
diff --git a/runtime/bin/platform_win.cc b/runtime/bin/platform_win.cc
index 53293024268d10d64ac94f5734632f3716d447ab..18526517e9ff2bd72c742d36a6a46bfdd3d30805 100644
--- a/runtime/bin/platform_win.cc
+++ b/runtime/bin/platform_win.cc
@@ -90,12 +90,9 @@ class PlatformWin {
const DWORD request = out_mode | ENABLE_VIRTUAL_TERMINAL_PROCESSING;
SetConsoleMode(out, request);
}
- HANDLE in = GetStdHandle(STD_INPUT_HANDLE);
- DWORD in_mode;
- if ((in != INVALID_HANDLE_VALUE) && GetConsoleMode(in, &in_mode)) {
- const DWORD request = in_mode | ENABLE_VIRTUAL_TERMINAL_INPUT;
- SetConsoleMode(in, request);
- }
+ // TODO(28984): Due to issue #29104, we cannot set
+ // ENABLE_VIRTUAL_TERMINAL_INPUT here, as it causes ENABLE_PROCESSED_INPUT
+ // to be ignored.
}
static void RestoreConsole() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698