Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: src/compiler/verifier.cc

Issue 2763533002: [WIP] JSForInLowering and JSForInHasOwnProperty.
Patch Set: Hack around the issue with indices not being available always. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/types.h ('k') | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/verifier.cc
diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index 3625b3608d72586a971ac4b9b3259ccfd179e780..7e0a2f0e3bbc89370f2f98d5c9359a987b468ea1 100644
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -726,6 +726,14 @@ void Verifier::Visitor::Check(Node* node) {
CheckTypeIs(node, Type::Any());
break;
}
+ case IrOpcode::kJSForInLoadProperty: {
+ CheckTypeIs(node, Type::NonInternal());
+ break;
+ }
+ case IrOpcode::kJSForInHasOwnProperty: {
+ CheckTypeIs(node, Type::Boolean());
+ break;
+ }
case IrOpcode::kJSForInNext: {
CheckTypeIs(node, Type::Union(Type::Name(), Type::Undefined(), zone));
break;
@@ -1208,6 +1216,12 @@ void Verifier::Visitor::Check(Node* node) {
CheckTypeIs(node, Type::NonInternal());
break;
+ case IrOpcode::kLoadFieldByIndex:
+ // (Any, Signed32) -> NonInternal
+ CheckValueInputIs(node, 0, Type::Any());
+ CheckValueInputIs(node, 1, Type::Signed32());
+ CheckTypeIs(node, Type::NonInternal());
+ break;
case IrOpcode::kLoadField:
// Object -> fieldtype
// TODO(rossberg): activate once machine ops are typed.
« no previous file with comments | « src/compiler/types.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698