Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(70)

Issue 2763433002: Add IOS_BUNDLE_ID_PREFIX to Clean Skeleton target. (Closed)

Created:
8 months, 3 weeks ago by lpromero
Modified:
8 months, 3 weeks ago
Reviewers:
sdefresne, Olivier
CC:
chromium-reviews, marq+scrutinize_chromium.org, lpromero+watch_chromium.org, ios-reviews+clean_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add IOS_BUNDLE_ID_PREFIX to Clean Skeleton target. If this is not set, the resulting Info.plist features "${IOS_BUNDLE_ID_PREFIX}" unsubstituted. BUG=none R=sdefresne@chromium.org Review-Url: https://codereview.chromium.org/2763433002 Cr-Commit-Position: refs/heads/master@{#458041} Committed: https://chromium.googlesource.com/chromium/src/+/38bf28aba38d3a8806122069504a36b0aa5cc3a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/clean/chrome/app/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
Trybot results:  linux_chromium_chromeos_rel_ng   win_chromium_rel_ng   win_clang   win_chromium_compile_dbg_ng   win_chromium_x64_rel_ng   win_chromium_rel_ng   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   ios-simulator   ios-device   ios-device-xcode-clang   ios-simulator-xcode-clang   linux_chromium_asan_rel_ng   linux_chromium_compile_dbg_ng   cast_shell_android   chromeos_daisy_chromium_compile_only_ng   linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   linux_chromium_chromeos_rel_ng   android_clang_dbg_recipe   linux_chromium_chromeos_ozone_rel_ng   android_compile_dbg   cast_shell_linux   android_arm64_dbg_recipe   linux_android_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   android_n5x_swarming_rel   chromium_presubmit   android_cronet   linux_chromium_chromeos_rel_ng   chromium_presubmit   mac_chromium_rel_ng   win_chromium_x64_rel_ng   chromeos_daisy_chromium_compile_only_ng   mac_chromium_compile_dbg_ng   win_chromium_rel_ng   linux_chromium_tsan_rel_ng   linux_android_rel_ng   ios-simulator   android_cronet   ios-device   cast_shell_android   chromeos_amd64-generic_chromium_compile_only_ng   win_clang   ios-simulator-xcode-clang   linux_chromium_chromeos_rel_ng   android_clang_dbg_recipe   ios-device-xcode-clang   linux_chromium_rel_ng   linux_chromium_compile_dbg_ng   android_compile_dbg   android_n5x_swarming_rel   win_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   cast_shell_linux   android_arm64_dbg_recipe   linux_chromium_asan_rel_ng 

Messages

Total messages: 16 (9 generated)
lpromero
8 months, 3 weeks ago (2017-03-19 00:09:17 UTC) #1
lpromero
+olivierrobin
8 months, 3 weeks ago (2017-03-20 10:42:02 UTC) #7
sdefresne
lgtm
8 months, 3 weeks ago (2017-03-20 10:51:20 UTC) #9
Olivier
lgtm
8 months, 3 weeks ago (2017-03-20 10:52:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763433002/1
8 months, 3 weeks ago (2017-03-20 10:54:16 UTC) #12
lpromero
Thanks!
8 months, 3 weeks ago (2017-03-20 10:54:21 UTC) #13
commit-bot: I haz the power
8 months, 3 weeks ago (2017-03-20 12:12:18 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/38bf28aba38d3a8806122069504a...

Powered by Google App Engine
This is Rietveld 0eb02b776