Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 2763363002: Use SVGResources in SVGLayoutTreeAsText writeResources (Closed)

Created:
3 years, 9 months ago by fs
Modified:
3 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, fmalita+watch_chromium.org, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SVGResources in SVGLayoutTreeAsText writeResources As the FIXME suggests, this should better reflect the actual state of the resources resolution by including the cycle-solving step. Some tests (recursive-clip/mask, clip-path-recursive-call-by-child) needs to be updated to reflect the change to actually show cycles having been broken. The rests of the tests are updated to reflect that LayoutSVGInlineText can't have resources. BUG=454767 Review-Url: https://codereview.chromium.org/2763363002 Cr-Commit-Position: refs/heads/master@{#459119} Committed: https://chromium.googlesource.com/chromium/src/+/0e50a38b387adde5829f18e549917fea3a06a494

Patch Set 1 #

Patch Set 2 : TEs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -125 lines) Patch
M third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/smallFonts-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textEffect-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textEffect3-expected.txt View 1 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textFeatures-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/custom/recursive-clippath-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/custom/recursive-mask-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/custom/text-clip-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/custom/text-filter-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/filters/filter-on-filter-for-text-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/filters/filter-on-tspan-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/svg/transforms/text-with-mask-with-svg-transform-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/smallFonts-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textEffect-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textEffect3-expected.txt View 1 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textFeatures-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/custom/recursive-clippath-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/custom/recursive-mask-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/custom/text-clip-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/custom/text-filter-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/filters/filter-on-filter-for-text-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/filters/filter-on-tspan-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/batik/text/smallFonts-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textEffect-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textEffect3-expected.txt View 1 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textFeatures-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/custom/recursive-clippath-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/custom/recursive-mask-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/custom/text-clip-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/custom/text-filter-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/filters/filter-on-filter-for-text-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/filters/filter-on-tspan-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/svg/transforms/text-with-mask-with-svg-transform-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/clip-path/clip-path-recursive-call-by-child-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutTreeAsText.cpp View 2 chunks +42 lines, -58 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
fs
3 years, 9 months ago (2017-03-22 20:02:37 UTC) #9
Stephen Chennney
Always good to see the true state of the world. LGTM.
3 years, 9 months ago (2017-03-23 16:24:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763363002/20001
3 years, 9 months ago (2017-03-23 16:37:03 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 16:47:15 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0e50a38b387adde5829f18e54991...

Powered by Google App Engine
This is Rietveld 408576698