Disable incremental linking for proto_zero_plugin

Disable incremental linking for proto_zero_plugin

This CL works around a linker bug that is seen when incrementally
linking proto_zero_plugin.exe after crrev.com/2756543002.

The linker bug also occurs in VS 2017 RTM so a new bug report to
Microsoft was made:
https://developercommunity.visualstudio.com/content/problem/34236/incremental-linking-creates-corrupt-executable.html

BUG=703251
R=primiano@chromium.org

Review-Url: https://codereview.chromium.org/2763233002
Cr-Commit-Position: refs/heads/master@{#458802}
Committed: https://chromium.googlesource.com/chromium/src/+/b5b19afd8b383045e4d9060eaf1be60da229745b

[Tom (Use chromium acct), 2017-03-22 01:09:10]

Description was changed from

==========
Disable incremental linking for proto_zero_plugin

This CL works around a linker bug that is seen when incrementally
linking proto_zero_plugin.exe after
https://codereview.chromium.org/2756543002/.  This is likely another
instance of https://crbug.com/482671, for which Microsoft is aware of
the issue.

BUG=703251
R=primiano@chromium.org
==========

to

==========
Disable incremental linking for proto_zero_plugin

This CL works around a linker bug that is seen when incrementally
linking proto_zero_plugin.exe after
https://codereview.chromium.org/2756543002/.  This is likely another
instance of https://crbug.com/482671, for which Microsoft is aware of
the issue.

BUG=703251
R=primiano@chromium.org
==========

[Tom (Use chromium acct), 2017-03-22 01:09:20]

primiano@ ptal

[Tom (Use chromium acct), 2017-03-22 01:09:26]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 01:10:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom (Use chromium acct), 2017-03-22 01:27:45]

+brucedawson FYI

[commit-bot: I haz the power, 2017-03-22 03:12:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 03:12:19]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT,
build hasn't started yet, builder probably lacks capacity)

[Primiano Tucci (use gerrit), 2017-03-22 17:52:42]

lgtm

[brucedawson, 2017-03-22 17:59:31]

Description was changed from

==========
Disable incremental linking for proto_zero_plugin

This CL works around a linker bug that is seen when incrementally
linking proto_zero_plugin.exe after
https://codereview.chromium.org/2756543002/.  This is likely another
instance of https://crbug.com/482671, for which Microsoft is aware of
the issue.

BUG=703251
R=primiano@chromium.org
==========

to

==========
Disable incremental linking for proto_zero_plugin

This CL works around a linker bug that is seen when incrementally
linking proto_zero_plugin.exe after crrev.com/2756543002.

The linker bug also occurs in VS 2017 RTM so a new bug report to
Microsoft was made:
https://developercommunity.visualstudio.com/content/problem/34236/incremental...

BUG=703251
R=primiano@chromium.org
==========

[Tom (Use chromium acct), 2017-03-22 18:01:35]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-03-22 18:02:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-03-22 18:04:22]

On 2017/03/22 17:52:42, Primiano Tucci wrote:
> lgtm

I tweaked the description a bit - changed the codereview link to a crrev.com
link because that avoids confusion about which is the link to the current CL's
review page.

I also added a link to a freshly filed bug.

Contrary thought: I think this bug is triggered not by anything in
proto_zero_plugin but by the change from dynamic to static linking. Therefore,
disabling incremental linking for this target will not help us in the future.
So, maybe don't bother?

[commit-bot: I haz the power, 2017-03-22 18:10:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490205695053830, "parent_rev":
"27dc20f2cd65e5b0f6178fd98a756fccdef8490c", "commit_rev":
"b5b19afd8b383045e4d9060eaf1be60da229745b"}

[Tom (Use chromium acct), 2017-03-22 18:10:56]

The CQ bit was unchecked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-03-22 18:12:04]

Description was changed from

==========
Disable incremental linking for proto_zero_plugin

This CL works around a linker bug that is seen when incrementally
linking proto_zero_plugin.exe after crrev.com/2756543002.

The linker bug also occurs in VS 2017 RTM so a new bug report to
Microsoft was made:
https://developercommunity.visualstudio.com/content/problem/34236/incremental...

BUG=703251
R=primiano@chromium.org
==========

to

==========
Disable incremental linking for proto_zero_plugin

This CL works around a linker bug that is seen when incrementally
linking proto_zero_plugin.exe after crrev.com/2756543002.

The linker bug also occurs in VS 2017 RTM so a new bug report to
Microsoft was made:
https://developercommunity.visualstudio.com/content/problem/34236/incremental...

BUG=703251
R=primiano@chromium.org

Review-Url: https://codereview.chromium.org/2763233002
Cr-Commit-Position: refs/heads/master@{#458802}
Committed:
https://chromium.googlesource.com/chromium/src/+/b5b19afd8b383045e4d9060eaf1b...
==========

[commit-bot: I haz the power, 2017-03-22 18:12:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b5b19afd8b383045e4d9060eaf1b...