Move showAutofillSettings to PreferencesLauncher.

Move showAutofillSettings to PreferencesLauncher.

As part of trimming ChromeApplication, this CL moves
showAutofillSettings to PreferencesLauncher and creates the necessary
native wrapper.

BUG=698009
Review-Url: https://codereview.chromium.org/2763133002
Cr-Commit-Position: refs/heads/master@{#459519}
Committed: https://chromium.googlesource.com/chromium/src/+/a85c276d44c938ac979097bc5c73bf4304a92951

[estevenson, 2017-03-21 20:02:39]

estevenson@chromium.org changed reviewers:
+ tedchoc@chromium.org

[estevenson, 2017-03-21 20:02:39]

ptal Ted!

If you think this approach is fine I'll also move
ChromeApplication#showPasswordSettings and
ChromeApplication#openClearBrowsingData to PreferencesLauncher as well. 

This is for trimming down ChromeApplication (http://crbug.com/560466), I
couldn't find a great place for these functions - but I think moving them to
PreferencesLauncher is a better fit than ChromeApplication. Another option would
be to create a separate class for each one but that seems kind of silly.

[Ted C, 2017-03-21 23:47:46]

lgtm

https://codereview.chromium.org/2763133002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesLauncher.java
(right):

https://codereview.chromium.org/2763133002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesLauncher.java:67:
public static void showAutofillSettings() {
private now?

[estevenson, 2017-03-22 12:29:10]

The CQ bit was checked by estevenson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 12:29:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 13:18:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 13:18:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[estevenson, 2017-03-22 13:43:21]

Description was changed from

==========
Move settings @CalledByNative functions to PreferencesLauncher.

BUG=698009
==========

to

==========
As part of trimming ChromeApplication, this CL moves showAutofillSettings to
PreferencesLauncher and creates the necessary native wrapper.

BUG=698009
==========

[estevenson, 2017-03-22 13:46:40]

Description was changed from

==========
As part of trimming ChromeApplication, this CL moves showAutofillSettings to
PreferencesLauncher and creates the necessary native wrapper.

BUG=698009
==========

to

==========
Move showAutofillSettings to PreferencesLauncher.

As part of trimming ChromeApplication, this CL moves
showAutofillSettings to PreferencesLauncher and creates the necessary
native wrapper.

BUG=698009
==========

[estevenson, 2017-03-22 14:29:14]

estevenson@chromium.org changed reviewers:
+ mathp@chromium.org

[estevenson, 2017-03-22 14:29:14]

+mathp@ for chrome/browser/ui/autofill OWNERS.

https://codereview.chromium.org/2763133002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesLauncher.java
(right):

https://codereview.chromium.org/2763133002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesLauncher.java:67:
public static void showAutofillSettings() {
On 2017/03/21 23:47:46, Ted C wrote:
> private now?

Done.

[Mathieu, 2017-03-23 14:48:05]

lgtm sorry for delay

[estevenson, 2017-03-24 18:10:59]

The CQ bit was checked by estevenson@chromium.org

[estevenson, 2017-03-24 18:10:59]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2763133002/#ps20001
(title: "Move settings @CalledByNative functions to PreferencesLauncher.")

[commit-bot: I haz the power, 2017-03-24 18:11:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 19:27:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490379059492350,
"parent_rev": "bd4d5b1c2309f56f76a72b3976b95518b152a08a", "commit_rev":
"a85c276d44c938ac979097bc5c73bf4304a92951"}

[commit-bot: I haz the power, 2017-03-24 19:28:38]

Description was changed from

==========
Move showAutofillSettings to PreferencesLauncher.

As part of trimming ChromeApplication, this CL moves
showAutofillSettings to PreferencesLauncher and creates the necessary
native wrapper.

BUG=698009
==========

to

==========
Move showAutofillSettings to PreferencesLauncher.

As part of trimming ChromeApplication, this CL moves
showAutofillSettings to PreferencesLauncher and creates the necessary
native wrapper.

BUG=698009

Review-Url: https://codereview.chromium.org/2763133002
Cr-Commit-Position: refs/heads/master@{#459519}
Committed:
https://chromium.googlesource.com/chromium/src/+/a85c276d44c938ac979097bc5c73...
==========

[commit-bot: I haz the power, 2017-03-24 19:28:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a85c276d44c938ac979097bc5c73...