Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2763123003: Remove a bunch of unused frameHost() methods (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
haraken, slangley, dglazkov
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, kinuko+watch, Navid Zolghadr, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a bunch of unused frameHost() methods Remove a bunch of unused frameHost() getter methods, including one on Document which required removing existing callsites. This is pre-work to remove FrameHost. BUG=688614 Review-Url: https://codereview.chromium.org/2763123003 Cr-Commit-Position: refs/heads/master@{#458668} Committed: https://chromium.googlesource.com/chromium/src/+/24ff0d2969d34f71b43f9f2b96f7ce4d7f0bfd37

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -42 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 3 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/input/GestureManager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/GestureManager.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/RootScrollerTest.cpp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
sashab
3 years, 9 months ago (2017-03-22 02:20:11 UTC) #3
slangley
lgtm
3 years, 9 months ago (2017-03-22 02:54:45 UTC) #5
sashab
haraken ptal :)
3 years, 9 months ago (2017-03-22 02:55:16 UTC) #7
dglazkov
lgtm
3 years, 9 months ago (2017-03-22 03:03:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763123003/1
3 years, 9 months ago (2017-03-22 03:04:32 UTC) #12
haraken
LGTM
3 years, 9 months ago (2017-03-22 03:30:11 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 9 months ago (2017-03-22 04:21:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763123003/1
3 years, 9 months ago (2017-03-22 05:36:59 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 07:35:03 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/24ff0d2969d34f71b43f9f2b96f7...

Powered by Google App Engine
This is Rietveld 408576698