Upstream service worker `claim` tests to WPT

Upstream service worker `claim` tests to WPT

BUG=688116, 675540
R=falken@chromium.org

Review-Url: https://codereview.chromium.org/2763123002
Cr-Commit-Position: refs/heads/master@{#459538}
Committed: https://chromium.googlesource.com/chromium/src/+/420b56c73fae6392e98998f0588af0f54d79436d

[mike3, 2017-03-21 19:47:38]

@falken This batch really only migrates one new test file:
`claim-with-redirect.html`. The files named `claim-not-using-registration.html`
and `claim-using-registration.html` were nearly identical to existing
`.https.html`-named counterparts in WPT (although comparing them highlighted
the fact that the WPT versions reference unneeded "resource" files).

This was a typical migration: updating file names, specifying HTTPS instead of
HTTP, and re-writing a small PHP script to Python. Here's a diff, generated via
`git show -M10`:

https://gist.github.com/jugglinmike/b406a854283746e73632263776288c46

The new tests also pass in Firefox Nightly :)

[falken, 2017-03-22 13:39:00]

lgtm

https://codereview.chromium.org/2763123002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/update-claim-worker.py
(right):

https://codereview.chromium.org/2763123002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/update-claim-worker.py:22:
# can find a new version in the network.
FYI: I think this is no longer true in the current spec, after the changes
resulting from https://github.com/w3c/ServiceWorker/issues/893. However, it is
still true in Chrome's implementation, until we've fixed
https://bugs.chromium.org/p/chromium/issues/detail?id=675540

I'd prefer to keep the no-cache headers here with a TODO comment that it's only
needed so Chrome can use this test until it fixes the bug.

[mike3, 2017-03-22 23:03:57]

https://codereview.chromium.org/2763123002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/update-claim-worker.py
(right):

https://codereview.chromium.org/2763123002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/update-claim-worker.py:22:
# can find a new version in the network.
On 2017/03/22 13:39:00, falken wrote:
> FYI: I think this is no longer true in the current spec, after the changes
> resulting from https://github.com/w3c/ServiceWorker/issues/893. However, it is
> still true in Chrome's implementation, until we've fixed
> https://bugs.chromium.org/p/chromium/issues/detail?id=675540
> 
> I'd prefer to keep the no-cache headers here with a TODO comment that it's
only
> needed so Chrome can use this test until it fixes the bug.

Oh, I missed that altogether. Now that you mention it, though, the this seems
like the kind of thing this test could be helping new implementations (e.g.
Edge, Safari) avoid shipping in the first place. I know we don't want to
regress Chromium's test coverage, though, so what do you think about this
approach:

1. remove the headers from this version
2. disable the test in Chromium's infrastructure
3. re-introduce the original version to the dedicated `chromium/` sub-directory
   of `http`?

[falken, 2017-03-22 23:09:56]

On 2017/03/22 23:03:57, mike3 wrote:
>
https://codereview.chromium.org/2763123002/diff/1/third_party/WebKit/LayoutTe...
> File
>
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/update-claim-worker.py
> (right):
> 
>
https://codereview.chromium.org/2763123002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/update-claim-worker.py:22:
> # can find a new version in the network.
> On 2017/03/22 13:39:00, falken wrote:
> > FYI: I think this is no longer true in the current spec, after the changes
> > resulting from https://github.com/w3c/ServiceWorker/issues/893. However, it
is
> > still true in Chrome's implementation, until we've fixed
> > https://bugs.chromium.org/p/chromium/issues/detail?id=675540
> > 
> > I'd prefer to keep the no-cache headers here with a TODO comment that it's
> only
> > needed so Chrome can use this test until it fixes the bug.
> 
> Oh, I missed that altogether. Now that you mention it, though, the this seems
> like the kind of thing this test could be helping new implementations (e.g.
> Edge, Safari) avoid shipping in the first place. I know we don't want to
> regress Chromium's test coverage, though, so what do you think about this
> approach:
> 
> 1. remove the headers from this version
> 2. disable the test in Chromium's infrastructure
> 3. re-introduce the original version to the dedicated `chromium/`
sub-directory
>    of `http`?

you're right, that would be the proper way to do it. sgtm.

[mike3, 2017-03-23 15:56:56]

@falken I've added another version of the test, this one its original form.
Would you mind taking another look?

https://codereview.chromium.org/2763123002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/update-claim-worker.py
(right):

https://codereview.chromium.org/2763123002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/update-claim-worker.py:6:
// previously-fetched version of this script.)
This is becoming something of a pattern in WPT. I plan to follow-up with a
generalized "prefix timestamp" Python handler in WPT.

[falken, 2017-03-24 09:18:26]

lgtm, just add 675540 to the BUG= for future reference.

[mike3, 2017-03-24 19:12:12]

Description was changed from

==========
Upstream service worker `claim` tests to WPT

BUG=688116
R=falken@chromium.org
==========

to

==========
Upstream service worker `claim` tests to WPT

BUG=688116, 675540
R=falken@chromium.org
==========

[mike3, 2017-03-24 19:12:39]

On 2017/03/24 09:18:26, falken wrote:
> lgtm, just add 675540 to the BUG= for future reference.

Got it

[mike3, 2017-03-24 19:12:44]

The CQ bit was checked by mike@mikepennisi.com

[commit-bot: I haz the power, 2017-03-24 19:13:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 20:31:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490382764293310,
"parent_rev": "22f8c680aa180e30b0bb41ecbd6a38af2eccad7a", "commit_rev":
"420b56c73fae6392e98998f0588af0f54d79436d"}

[commit-bot: I haz the power, 2017-03-24 20:35:25]

Description was changed from

==========
Upstream service worker `claim` tests to WPT

BUG=688116, 675540
R=falken@chromium.org
==========

to

==========
Upstream service worker `claim` tests to WPT

BUG=688116, 675540
R=falken@chromium.org

Review-Url: https://codereview.chromium.org/2763123002
Cr-Commit-Position: refs/heads/master@{#459538}
Committed:
https://chromium.googlesource.com/chromium/src/+/420b56c73fae6392e98998f0588a...
==========

[commit-bot: I haz the power, 2017-03-24 20:35:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/420b56c73fae6392e98998f0588a...