Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issue 2763113002: Upstream service worker postMessage tests to WPT (Closed)

Created:
3 years, 9 months ago by mike3
Modified:
3 years, 9 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-w3ctests_chromium.org, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream service worker postMessage tests to WPT BUG=688116 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2763113002 Cr-Commit-Position: refs/heads/master@{#458941} Committed: https://chromium.googlesource.com/chromium/src/+/4f03d873326c61514cea9f4b4f293c43a7327b76

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -110 lines) Patch
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/postmessage.https.html View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/postmessage-loopback-worker.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/postmessage-ping-worker.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/postmessage-pong-worker.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/postmessage.html View 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/postmessage-loopback-worker.js View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/postmessage-ping-worker.js View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/postmessage-pong-worker.js View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mike3
@falken Some of the tests in `ServiceWorkerGlobalScope` rely on global state, making them potentially flaky. ...
3 years, 9 months ago (2017-03-21 18:44:14 UTC) #1
falken
lgtm small patches are very welcome :)
3 years, 9 months ago (2017-03-22 13:29:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763113002/1
3 years, 9 months ago (2017-03-22 22:34:14 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 00:08:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f03d873326c61514cea9f4b4f29...

Powered by Google App Engine
This is Rietveld 408576698