cocoa: draw new tab button with heavier stroke in high contrast

cocoa: draw new tab button with heavier stroke in high contrast

This change makes the new tab button draw with 100% alpha when "increase
contrast" is enabled.

BUG=696237
Review-Url: https://codereview.chromium.org/2763093002
Cr-Commit-Position: refs/heads/master@{#459120}
Committed: https://chromium.googlesource.com/chromium/src/+/712a32b9cdf3b50e63eb25f62e901eff8e84ccf9

[Elly Fong-Jones, 2017-03-21 16:27:18]

Description was changed from

==========
cocoa: draw new tab button with heavier stroke in high contrast

This change makes the new tab button draw with 100% alpha when "increase
contrast" is enabled.

BUG=696237
==========

to

==========
cocoa: draw new tab button with heavier stroke in high contrast

This change makes the new tab button draw with 100% alpha when "increase
contrast" is enabled.

BUG=696237
==========

[Elly Fong-Jones, 2017-03-21 16:27:19]

ellyjones@chromium.org changed reviewers:
+ mark@chromium.org

[Elly Fong-Jones, 2017-03-21 16:27:28]

mark: ptal? :)

[Mark Mentovai, 2017-03-22 17:02:56]

LGTM otherwise

https://codereview.chromium.org/2763093002/diff/1/chrome/browser/ui/cocoa/new...
File chrome/browser/ui/cocoa/new_tab_button.mm (right):

https://codereview.chromium.org/2763093002/diff/1/chrome/browser/ui/cocoa/new...
chrome/browser/ui/cocoa/new_tab_button.mm:28: const NSSize newTabButtonImageSize
= { 34, 18 };
Fix the messed-up indentation on this while you’re here.

https://codereview.chromium.org/2763093002/diff/1/chrome/browser/ui/cocoa/new...
chrome/browser/ui/cocoa/new_tab_button.mm:30: const CGFloat k7PercentAlpha =
0.07;
Umm…do we really need these constants?

If they had semantic meaning, they’d be fine. kMarginallyTranslucent,
kPrettyDarnTranslucent, kTotallyOpaque, etc. (I’m joking.) But as they are now,
it’s basically the same as

#define NINE 9

[Elly Fong-Jones, 2017-03-23 16:22:38]

https://codereview.chromium.org/2763093002/diff/1/chrome/browser/ui/cocoa/new...
File chrome/browser/ui/cocoa/new_tab_button.mm (right):

https://codereview.chromium.org/2763093002/diff/1/chrome/browser/ui/cocoa/new...
chrome/browser/ui/cocoa/new_tab_button.mm:28: const NSSize newTabButtonImageSize
= { 34, 18 };
On 2017/03/22 17:02:55, Mark Mentovai wrote:
> Fix the messed-up indentation on this while you’re here.

Done.

https://codereview.chromium.org/2763093002/diff/1/chrome/browser/ui/cocoa/new...
chrome/browser/ui/cocoa/new_tab_button.mm:30: const CGFloat k7PercentAlpha =
0.07;
On 2017/03/22 17:02:56, Mark Mentovai wrote:
> Umm…do we really need these constants?
> 
> If they had semantic meaning, they’d be fine. kMarginallyTranslucent,
> kPrettyDarnTranslucent, kTotallyOpaque, etc. (I’m joking.) But as they are
now,
> it’s basically the same as
> 
> #define NINE 9

It is done.

[Elly Fong-Jones, 2017-03-23 16:22:41]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2017-03-23 16:22:42]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2763093002/#ps20001
(title: "fix nits :)")

[commit-bot: I haz the power, 2017-03-23 16:23:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 16:48:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490286161692060,
"parent_rev": "0e50a38b387adde5829f18e549917fea3a06a494", "commit_rev":
"712a32b9cdf3b50e63eb25f62e901eff8e84ccf9"}

[commit-bot: I haz the power, 2017-03-23 16:49:36]

Description was changed from

==========
cocoa: draw new tab button with heavier stroke in high contrast

This change makes the new tab button draw with 100% alpha when "increase
contrast" is enabled.

BUG=696237
==========

to

==========
cocoa: draw new tab button with heavier stroke in high contrast

This change makes the new tab button draw with 100% alpha when "increase
contrast" is enabled.

BUG=696237

Review-Url: https://codereview.chromium.org/2763093002
Cr-Commit-Position: refs/heads/master@{#459120}
Committed:
https://chromium.googlesource.com/chromium/src/+/712a32b9cdf3b50e63eb25f62e90...
==========

[commit-bot: I haz the power, 2017-03-23 16:49:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/712a32b9cdf3b50e63eb25f62e90...