Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Issue 2763033002: [Doodle] Add an about:flags entry for the new Doodle API (Closed)

Created:
3 years, 9 months ago by Marc Treib
Modified:
3 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews, srahim+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Doodle] Add an about:flags entry for the new Doodle API This required moving the feature definition into chrome_feature_list.h/cc TBRing an enum-only change to histograms.xml TBR=asvitkine BUG=690467 Review-Url: https://codereview.chromium.org/2763033002 Cr-Commit-Position: refs/heads/master@{#458689} Committed: https://chromium.googlesource.com/chromium/src/+/cf033386ba09e928863f0aaed7aa0cd94323369c

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : histograms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/android/logo_bridge.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
Marc Treib
PTAL! (normally I'd send this to bauerb, but he's out this week) Thanks!
3 years, 9 months ago (2017-03-21 13:52:43 UTC) #8
Ted C
lgtm
3 years, 9 months ago (2017-03-22 03:53:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763033002/40001
3 years, 9 months ago (2017-03-22 08:51:33 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 08:57:17 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cf033386ba09e928863f0aaed7aa...

Powered by Google App Engine
This is Rietveld 408576698