Specify AllowCaching = false for some ChromeOS UI pages

Specify AllowCaching = false for some ChromeOS UI pages

This patch modifies some ChromeOS specific code that provide
dynamically-generated contents for WebUI. This change ensures
that generated contents are not cached in Blink memory cache.

BUG=669776
Review-Url: https://codereview.chromium.org/2763013003
Cr-Commit-Position: refs/heads/master@{#459360}
Committed: https://chromium.googlesource.com/chromium/src/+/563228463c7cdd0b8e87f960dacb11c97698d84e

[Takashi Toyoshima, 2017-03-22 08:45:27]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 08:45:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2017-03-22 08:46:14]

Description was changed from

==========
Specify AllowCaching = false for some ChromeOS UI pages

This patch modifies some ChromeOS specific code that provide
dynamically-generated contents for WebUI. This change ensures
that generated contents are not cached in Blink memory cache.

BUG=669776
==========

to

==========
Specify AllowCaching = false for some ChromeOS UI pages

This patch modifies some ChromeOS specific code that provide
dynamically-generated contents for WebUI. This change ensures
that generated contents are not cached in Blink memory cache.

BUG=669776
==========

[Takashi Toyoshima, 2017-03-22 08:46:14]

toyoshim@chromium.org changed reviewers:
+ stevenjb@chromium.org

[commit-bot: I haz the power, 2017-03-22 09:02:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 09:02:43]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[stevenjb, 2017-03-22 20:50:29]

https://codereview.chromium.org/2763013003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/certificate_manager_dialog_ui.h (right):

https://codereview.chromium.org/2763013003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/certificate_manager_dialog_ui.h:29: bool
AllowCaching() const override;
Override from what class? e.g. see comment on line 32

https://codereview.chromium.org/2763013003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/mobile_setup_ui.h (right):

https://codereview.chromium.org/2763013003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/mobile_setup_ui.h:21: bool AllowCaching() const
override;
override comment e.g. line 24.
The comment format varies from class to class, be consistent within a class and
feel free to simplify across the class, the following is sufficient:

  // content::WebContentsObserver
  void DidFinishNavigation(...) override;

https://codereview.chromium.org/2763013003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc (right):

https://codereview.chromium.org/2763013003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc:97: bool
SimUnlockUI::AllowCaching() const override { return false; }
no SimUnlockUI::

[Takashi Toyoshima, 2017-03-23 05:54:39]

Sorry, the last patch still contain many errors.
Let me see the next try results.

https://codereview.chromium.org/2763013003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/certificate_manager_dialog_ui.h (right):

https://codereview.chromium.org/2763013003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/certificate_manager_dialog_ui.h:29: bool
AllowCaching() const override;
Sorry, this CL wasn't published yet, and current state is just for finding this
kind of errors via trybots because the change was just made from a file list and
wasn't built locally. (But I already added you to the reviewer list. Sorry for
that).

https://codereview.chromium.org/2763013003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/mobile_setup_ui.h (right):

https://codereview.chromium.org/2763013003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/mobile_setup_ui.h:21: bool AllowCaching() const
override;
On 2017/03/22 20:50:29, stevenjb wrote:
> override comment e.g. line 24.
> The comment format varies from class to class, be consistent within a class
and
> feel free to simplify across the class, the following is sufficient:
> 
>   // content::WebContentsObserver
>   void DidFinishNavigation(...) override;

Acknowledged.

https://codereview.chromium.org/2763013003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc (right):

https://codereview.chromium.org/2763013003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc:97: bool
SimUnlockUI::AllowCaching() const override { return false; }
On 2017/03/22 20:50:29, stevenjb wrote:
> no SimUnlockUI::

Acknowledged.

[Takashi Toyoshima, 2017-03-23 08:59:44]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 09:00:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2017-03-23 09:01:03]

OK, please review the patch set 4.

Thanks!

[commit-bot: I haz the power, 2017-03-23 09:29:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 09:29:24]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2017-03-23 16:49:05]

lgtm

[Takashi Toyoshima, 2017-03-24 04:16:01]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2017-03-24 04:16:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 04:21:11]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490328961576390,
"parent_rev": "1597c7cd9c2606316e97bb18691a5d12f0737092", "commit_rev":
"563228463c7cdd0b8e87f960dacb11c97698d84e"}

[commit-bot: I haz the power, 2017-03-24 04:21:58]

Description was changed from

==========
Specify AllowCaching = false for some ChromeOS UI pages

This patch modifies some ChromeOS specific code that provide
dynamically-generated contents for WebUI. This change ensures
that generated contents are not cached in Blink memory cache.

BUG=669776
==========

to

==========
Specify AllowCaching = false for some ChromeOS UI pages

This patch modifies some ChromeOS specific code that provide
dynamically-generated contents for WebUI. This change ensures
that generated contents are not cached in Blink memory cache.

BUG=669776

Review-Url: https://codereview.chromium.org/2763013003
Cr-Commit-Position: refs/heads/master@{#459360}
Committed:
https://chromium.googlesource.com/chromium/src/+/563228463c7cdd0b8e87f960dacb...
==========

[commit-bot: I haz the power, 2017-03-24 04:21:59]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/563228463c7cdd0b8e87f960dacb...