Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2762943005: Rebaseline paint/invalidation/paged-with-overflowing-block-rl.html (Closed)

Created:
3 years, 9 months ago by Stephen Chennney
Modified:
3 years, 9 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebaseline paint/invalidation/paged-with-overflowing-block-rl.html The result regressed when a more serious issue was fixed. It's not likely to get fixed real soon, so rebaseline the result to get coverage of other changes but leave th ebug open so we know we're failing. TBR=mstensho@opera.com BUG=683339 Review-Url: https://codereview.chromium.org/2762943005 Cr-Commit-Position: refs/heads/master@{#458844} Committed: https://chromium.googlesource.com/chromium/src/+/959aa7f6f37c53cd282c7e4a9495a648f43847e2

Patch Set 1 #

Patch Set 2 : New baselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/paged-with-overflowing-block-rl-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/paged-with-overflowing-block-rl-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/paged-with-overflowing-block-rl-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/disable-spinvalidation/paint/invalidation/paged-with-overflowing-block-rl-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/paged-with-overflowing-block-rl-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/paged-with-overflowing-block-rl-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/paged-with-overflowing-block-rl-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/paged-with-overflowing-block-rl-expected.png View 1 Binary file 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762943005/20001
3 years, 9 months ago (2017-03-22 17:50:46 UTC) #2
mstensho (USE GERRIT)
lgtm - although I don't understand why the script insists on adding the virtual/disable-spinvalidation/paint/ expectations. ...
3 years, 9 months ago (2017-03-22 18:42:26 UTC) #3
Stephen Chennney
On 2017/03/22 18:42:26, mstensho wrote: > lgtm - although I don't understand why the script ...
3 years, 9 months ago (2017-03-22 19:12:20 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/959aa7f6f37c53cd282c7e4a9495a648f43847e2
3 years, 9 months ago (2017-03-22 19:41:05 UTC) #7
mstensho (USE GERRIT)
3 years, 9 months ago (2017-03-23 08:26:03 UTC) #8
Message was sent while issue was closed.
On 2017/03/22 19:12:20, Stephen Chennney wrote:
> On 2017/03/22 18:42:26, mstensho wrote:
> > lgtm - although I don't understand why the script insists on adding the
> > virtual/disable-spinvalidation/paint/ expectations. They should be identical
> to
> > the paint/ ones.
> 
> I'm not sure either. Based on file size they seem to be identical. I'll try
> removing them in a follow up.

Don't bother. I think I removed them manually last time I rebaseline-cl'ed this.
But that's just boring. If the script wants it this way, fine! :)

(or someone could fix the script, perhaps?)

Powered by Google App Engine
This is Rietveld 408576698