Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Issue 2762943003: Add a new UMA enum to record how many download uses parallel requests (Closed)

Created:
3 years, 9 months ago by qinmin
Modified:
3 years, 9 months ago
CC:
chromium-reviews, asanka, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a new UMA enum to record how many download uses parallel requests Only download item knows whether the internal state is INITIAL_INTERNAL So if we record the UMA in parallelDownloadJob, it could cause a multiple counting issue. BUG=644352 Review-Url: https://codereview.chromium.org/2762943003 Cr-Commit-Position: refs/heads/master@{#458977} Committed: https://chromium.googlesource.com/chromium/src/+/1c18f0dfcf0e06987105d4aed02449328ef5d893

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M content/browser/download/download_item_impl.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/download/download_job.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/download/download_job.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/download/download_stats.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/download/parallel_download_job.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/download/parallel_download_job.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
qinmin
PTAL
3 years, 9 months ago (2017-03-21 23:34:39 UTC) #2
xingliu
lgtm.
3 years, 9 months ago (2017-03-21 23:39:13 UTC) #3
Ilya Sherman
histograms.xml lgtm
3 years, 9 months ago (2017-03-22 00:20:31 UTC) #4
David Trainor- moved to gerrit
lgtm
3 years, 9 months ago (2017-03-22 03:15:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762943003/20001
3 years, 9 months ago (2017-03-22 19:15:33 UTC) #12
commit-bot: I haz the power
Failed to apply patch for content/browser/download/download_job.h: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-22 21:14:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762943003/40001
3 years, 9 months ago (2017-03-22 23:25:19 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 02:01:58 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1c18f0dfcf0e06987105d4aed024...

Powered by Google App Engine
This is Rietveld 408576698