Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1562)

Unified Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc

Issue 2762893002: Fix a lifetime issue in ToolbarActionsBarBubbleViews (Closed)
Patch Set: Update comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc
diff --git a/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc b/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc
index 9ccf93f806deb216355d8df3b0155390c64ba77e..f2122036ee38c9c6084caabfcc7d2e9b851a758a 100644
--- a/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc
+++ b/chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc
@@ -7,6 +7,7 @@
#include "chrome/browser/ui/extensions/extension_message_bubble_browsertest.h"
#include "chrome/browser/ui/test/test_browser_dialog.h"
#include "chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.h"
+#include "ui/accessibility/ax_node_data.h"
#include "ui/base/ui_base_switches.h"
#include "ui/views/bubble/bubble_dialog_delegate.h"
#include "ui/views/controls/link.h"
@@ -131,6 +132,13 @@ void ExtensionMessageBubbleViewBrowserTest::ClickLearnMoreButton(
ToolbarActionsBarBubbleViews* bubble = GetViewsBubbleForBrowser(browser);
static_cast<views::LinkListener*>(bubble)->LinkClicked(
const_cast<views::Link*>(bubble->learn_more_button()), 0);
+
+ // Clicking a button closes asynchronously. Since the close is asynchronous,
+ // platform events may happen before the close completes and the dialog needs
+ // to report a valid state.
+ ui::AXNodeData node_data;
+ bubble->GetAccessibleNodeData(&node_data);
+ EXPECT_EQ(ui::AX_ROLE_DIALOG, node_data.role);
}
void ExtensionMessageBubbleViewBrowserTest::ClickActionButton(
@@ -225,14 +233,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
TestBubbleWithMultipleWindows();
}
-// Crashes on Mac only. http://crbug.com/702554
-#if defined(OS_MACOSX)
-#define MAYBE_TestClickingLearnMoreButton DISABLED_TestClickingLearnMoreButton
-#else
-#define MAYBE_TestClickingLearnMoreButton TestClickingLearnMoreButton
-#endif
IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
- MAYBE_TestClickingLearnMoreButton) {
+ TestClickingLearnMoreButton) {
TestClickingLearnMoreButton();
}

Powered by Google App Engine
This is Rietveld 408576698