Fix a lifetime issue in ToolbarActionsBarBubbleViews

chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/auto_reset.h"
 #include "base/macros.h"
 #include "chrome/browser/ui/extensions/extension_message_bubble_browsertest.h"
 #include "chrome/browser/ui/test/test_browser_dialog.h"
 #include "chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.h"
+#include "ui/accessibility/ax_node_data.h"
 #include "ui/base/ui_base_switches.h"
 #include "ui/views/bubble/bubble_dialog_delegate.h"
 #include "ui/views/controls/link.h"
 #include "ui/views/controls/link_listener.h"
 #include "ui/views/window/dialog_client_view.h"
 
 namespace {
 
 // Checks that the |bubble| is showing. Uses |reference_bounds| to ensure it is
 // in approximately the correct position.
@@ skipping 104 matching lines @@
 void ExtensionMessageBubbleViewBrowserTest::CheckBubbleIsNotPresentNative(
     Browser* browser) {
   EXPECT_EQ(nullptr, GetViewsBubbleForBrowser(browser));
 }
 
 void ExtensionMessageBubbleViewBrowserTest::ClickLearnMoreButton(
     Browser* browser) {
   ToolbarActionsBarBubbleViews* bubble = GetViewsBubbleForBrowser(browser);
   static_cast<views::LinkListener*>(bubble)->LinkClicked(
       const_cast<views::Link*>(bubble->learn_more_button()), 0);
+
+  // Clicking a button closes asynchronously. Since the close is asynchronous,
+  // platform events may happen before the close completes and the dialog needs
+  // to report a valid state.
+  ui::AXNodeData node_data;
+  bubble->GetAccessibleNodeData(&node_data);
+  EXPECT_EQ(ui::AX_ROLE_DIALOG, node_data.role);
 }
 
 void ExtensionMessageBubbleViewBrowserTest::ClickActionButton(
     Browser* browser) {
   ToolbarActionsBarBubbleViews* bubble = GetViewsBubbleForBrowser(browser);
   bubble->GetDialogClientView()->AcceptWindow();
 }
 
 void ExtensionMessageBubbleViewBrowserTest::ClickDismissButton(
     Browser* browser) {
@@ skipping 74 matching lines @@
   TestControlledStartupNotShownOnRestart();
 }
 
 #endif  // defined(OS_WIN)
 
 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
                        TestBubbleWithMultipleWindows) {
   TestBubbleWithMultipleWindows();
 }
 
-// Crashes on Mac only.  http://crbug.com/702554
-#if defined(OS_MACOSX)
-#define MAYBE_TestClickingLearnMoreButton DISABLED_TestClickingLearnMoreButton
-#else
-#define MAYBE_TestClickingLearnMoreButton TestClickingLearnMoreButton
-#endif
 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
-                       MAYBE_TestClickingLearnMoreButton) {
+                       TestClickingLearnMoreButton) {
   TestClickingLearnMoreButton();
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
                        TestClickingActionButton) {
   TestClickingActionButton();
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
                        TestClickingDismissButton) {
   TestClickingDismissButton();
 }
 
 // BrowserDialogTest for the warning bubble that appears at startup when there
 // are extensions installed in developer mode. Can be invoked interactively with
 // --gtest_filter=BrowserDialogTest.Invoke.
 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
                        InvokeDialog_devmode_warning) {
   RunDialog();
 }