WebView: rename SafeBrowsing tests to be more consistent

WebView: rename SafeBrowsing tests to be more consistent

No logic change.

This CL renames safe browsing tests to a more useful naming scheme. For
each scenario, we need to test a malicious main frame and malicious
subresource separately. This naming convention makes that more explicit.

Also, this adds a message to one of the asserts that was missing one.

Review-Url: https://codereview.chromium.org/2762843002
Cr-Commit-Position: refs/heads/master@{#458275}
Committed: https://chromium.googlesource.com/chromium/src/+/cba28fc12c0dfe73592d9a6b08f5464d4aa468f0

[Nate Fischer, 2017-03-21 00:36:37]

ntfschr@chromium.org changed reviewers:
+ boliu@chromium.org

[Nate Fischer, 2017-03-21 00:36:45]

PTAL

[boliu, 2017-03-21 00:38:44]

lgtm

drop the "BUG=" part if there is no bug

[Nate Fischer, 2017-03-21 00:39:48]

On 2017/03/21 at 00:38:44, boliu wrote:
> lgtm
> 
> drop the "BUG=" part if there is no bug

Ok sure

[Nate Fischer, 2017-03-21 00:40:01]

Description was changed from

==========
WebView: rename SafeBrowsing tests to be more consistent

No logic change.

This CL renames safe browsing tests to a more useful naming scheme. For
each scenario, we need to test a malicious main frame and malicious
subresource separately. This naming convention makes that more explicit.

Also, this adds a message to one of the asserts that was missing one.

BUG=
==========

to

==========
WebView: rename SafeBrowsing tests to be more consistent

No logic change.

This CL renames safe browsing tests to a more useful naming scheme. For
each scenario, we need to test a malicious main frame and malicious
subresource separately. This naming convention makes that more explicit.

Also, this adds a message to one of the asserts that was missing one.
==========

[Nate Fischer, 2017-03-21 00:40:06]

The CQ bit was checked by ntfschr@chromium.org

[commit-bot: I haz the power, 2017-03-21 00:41:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 02:00:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490056806462380, "parent_rev":
"a8ee9decef09022c19cab0238a80487e96f408d4", "commit_rev":
"cba28fc12c0dfe73592d9a6b08f5464d4aa468f0"}

[commit-bot: I haz the power, 2017-03-21 02:01:05]

Description was changed from

==========
WebView: rename SafeBrowsing tests to be more consistent

No logic change.

This CL renames safe browsing tests to a more useful naming scheme. For
each scenario, we need to test a malicious main frame and malicious
subresource separately. This naming convention makes that more explicit.

Also, this adds a message to one of the asserts that was missing one.
==========

to

==========
WebView: rename SafeBrowsing tests to be more consistent

No logic change.

This CL renames safe browsing tests to a more useful naming scheme. For
each scenario, we need to test a malicious main frame and malicious
subresource separately. This naming convention makes that more explicit.

Also, this adds a message to one of the asserts that was missing one.

Review-Url: https://codereview.chromium.org/2762843002
Cr-Commit-Position: refs/heads/master@{#458275}
Committed:
https://chromium.googlesource.com/chromium/src/+/cba28fc12c0dfe73592d9a6b08f5...
==========

[commit-bot: I haz the power, 2017-03-21 02:01:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cba28fc12c0dfe73592d9a6b08f5...