Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2762773002: Remove the linker parameter from ChildProcessConnection. (Closed)

Created:
3 years, 9 months ago by Jay Civelli
Modified:
3 years, 9 months ago
Reviewers:
boliu
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the linker parameter from ChildProcessConnection. Removing a library loader linker specific parameter from the Android ChildProcessConnection class to make it more generic (it was always set to the same value). This is part of the effort to move Android child process creation to base/. BUG=702316 Review-Url: https://codereview.chromium.org/2762773002 Cr-Commit-Position: refs/heads/master@{#458267} Committed: https://chromium.googlesource.com/chromium/src/+/08f54ecc76964badb626b2426b6f01f46cac7717

Patch Set 1 #

Messages

Total messages: 13 (9 generated)
Jay Civelli
3 years, 9 months ago (2017-03-20 21:59:41 UTC) #6
boliu
lgtm
3 years, 9 months ago (2017-03-20 22:45:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762773002/1
3 years, 9 months ago (2017-03-20 23:36:32 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 01:23:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/08f54ecc76964badb626b2426b6f...

Powered by Google App Engine
This is Rietveld 408576698