Add PhysicalWeb.updateScans()

Add PhysicalWeb.updateScans()

This updateScans method simplifies the environment checks needed before
beginning or ending a scan.  Instead of each code path that may begin
or end a scan checking permissions by itself, based on what event has
just occurred, this method will check and update scans as needed.

This paves the way for an upgraded scanning API that will let client
code to the Physical Web request different scan policies.  On each
request, we will be able to simply call updateScans().

BUG=703308
Review-Url: https://codereview.chromium.org/2762733002
Cr-Commit-Position: refs/heads/master@{#458254}
Committed: https://chromium.googlesource.com/chromium/src/+/73b7f2fce6f5ef21212bb6482fd5cfa7ec9344f6

[cco3, 2017-03-20 20:03:52]

cco3@chromium.org changed reviewers:
+ mattreynolds@chromium.org

[cco3, 2017-03-20 20:03:53]

Hi Matt, enjoy a warm fresh CL, compliments of the chef.

[mattreynolds, 2017-03-20 20:47:50]

lgtm

https://codereview.chromium.org/2762733002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
(right):

https://codereview.chromium.org/2762733002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java:162:
|| locationUtils.isSystemLocationSettingEnabled()
Should this be !locationUtils.isSystemLocationSettingEnabled()?

[cco3, 2017-03-20 21:13:09]

https://codereview.chromium.org/2762733002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
(right):

https://codereview.chromium.org/2762733002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java:162:
|| locationUtils.isSystemLocationSettingEnabled()
On 2017/03/20 20:47:50, mattreynolds wrote:
> Should this be !locationUtils.isSystemLocationSettingEnabled()?

Done.

[cco3, 2017-03-20 21:17:10]

cco3@chromium.org changed reviewers:
+ dtrainor@chromium.org

[cco3, 2017-03-20 21:17:11]

Hi David, would you be able to take a look at this change?  Thanks.

[David Trainor- moved to gerrit, 2017-03-20 21:26:59]

lgtm

https://codereview.chromium.org/2762733002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
(right):

https://codereview.chromium.org/2762733002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java:159:
public static void updateScans() {
Javadoc

[cco3, 2017-03-20 21:35:01]

Thanks!

https://codereview.chromium.org/2762733002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
(right):

https://codereview.chromium.org/2762733002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java:159:
public static void updateScans() {
On 2017/03/20 21:26:59, David Trainor-ping if over 24h wrote:
> Javadoc

Done.

[cco3, 2017-03-20 21:35:17]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-03-20 21:35:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
mattreynolds@chromium.org, dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2762733002/#ps40001
(title: "Add javadoc")

[commit-bot: I haz the power, 2017-03-20 21:36:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 22:39:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 22:39:55]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[cco3, 2017-03-20 23:08:49]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-03-20 23:08:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2762733002/#ps60001
(title: "Remove dead store")

[commit-bot: I haz the power, 2017-03-20 23:09:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 00:34:51]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490051329204960,
"parent_rev": "cb77549102b06829a156e9ce71613afcaa185d3d", "commit_rev":
"73b7f2fce6f5ef21212bb6482fd5cfa7ec9344f6"}

[commit-bot: I haz the power, 2017-03-21 00:36:00]

Description was changed from

==========
Add PhysicalWeb.updateScans()

This updateScans method simplifies the environment checks needed before
beginning or ending a scan.  Instead of each code path that may begin
or end a scan checking permissions by itself, based on what event has
just occurred, this method will check and update scans as needed.

This paves the way for an upgraded scanning API that will let client
code to the Physical Web request different scan policies.  On each
request, we will be able to simply call updateScans().

BUG=703308
==========

to

==========
Add PhysicalWeb.updateScans()

This updateScans method simplifies the environment checks needed before
beginning or ending a scan.  Instead of each code path that may begin
or end a scan checking permissions by itself, based on what event has
just occurred, this method will check and update scans as needed.

This paves the way for an upgraded scanning API that will let client
code to the Physical Web request different scan policies.  On each
request, we will be able to simply call updateScans().

BUG=703308

Review-Url: https://codereview.chromium.org/2762733002
Cr-Commit-Position: refs/heads/master@{#458254}
Committed:
https://chromium.googlesource.com/chromium/src/+/73b7f2fce6f5ef21212bb6482fd5...
==========

[commit-bot: I haz the power, 2017-03-21 00:36:01]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/73b7f2fce6f5ef21212bb6482fd5...