Gtk3: Whitelist X11 backend

Gtk3: Whitelist X11 backend

Gtk can only have one window server backend active at a time.  On
systems running Wayland (like Fedora 25), Gtk will prefer the Wayland
backend over the X11 one.  This violates the assumption in libgtkui
about th euse of X11, and will eg. cause a crash on keypress in
X11InputMethodContextImplGtk.  The solution is to forbid Wayland using
gdk_set_allowed_backends("x11") prior to gtk_init().

BUG=702876
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2762723003
Cr-Commit-Position: refs/heads/master@{#458218}
Committed: https://chromium.googlesource.com/chromium/src/+/5d073abb6966b9c2d2ad1033c8a0e3396072c0f3

[Tom (Use chromium acct), 2017-03-20 20:52:38]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 20:53:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-03-20 21:01:41]

https://codereview.chromium.org/2762723003/diff/1/chrome/browser/ui/libgtkui/...
File chrome/browser/ui/libgtkui/gtk_util.cc (right):

https://codereview.chromium.org/2762723003/diff/1/chrome/browser/ui/libgtkui/...
chrome/browser/ui/libgtkui/gtk_util.cc:204: "libgdk-" +
std::to_string(GTK_MAJOR_VERSION) + ".so.0";
Is this ever not 3?

[Tom (Use chromium acct), 2017-03-20 21:04:46]

https://codereview.chromium.org/2762723003/diff/1/chrome/browser/ui/libgtkui/...
File chrome/browser/ui/libgtkui/gtk_util.cc (right):

https://codereview.chromium.org/2762723003/diff/1/chrome/browser/ui/libgtkui/...
chrome/browser/ui/libgtkui/gtk_util.cc:204: "libgdk-" +
std::to_string(GTK_MAJOR_VERSION) + ".so.0";
On 2017/03/20 21:01:41, Elliot Glaysher wrote:
> Is this ever not 3?

For now it is, but we'll need it for gtk4 ;)

[Elliot Glaysher, 2017-03-20 21:09:11]

lgtm

[commit-bot: I haz the power, 2017-03-20 21:52:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 21:52:26]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2017-03-20 21:52:40]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-03-20 21:53:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 22:58:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490046760573350, "parent_rev":
"0c5570d5cf495210b600a0b6fa3f3ec0b53a7b33", "commit_rev":
"5d073abb6966b9c2d2ad1033c8a0e3396072c0f3"}

[commit-bot: I haz the power, 2017-03-20 22:59:50]

Description was changed from

==========
Gtk3: Whitelist X11 backend

Gtk can only have one window server backend active at a time.  On
systems running Wayland (like Fedora 25), Gtk will prefer the Wayland
backend over the X11 one.  This violates the assumption in libgtkui
about th euse of X11, and will eg. cause a crash on keypress in
X11InputMethodContextImplGtk.  The solution is to forbid Wayland using
gdk_set_allowed_backends("x11") prior to gtk_init().

BUG=702876
R=erg@chromium.org
==========

to

==========
Gtk3: Whitelist X11 backend

Gtk can only have one window server backend active at a time.  On
systems running Wayland (like Fedora 25), Gtk will prefer the Wayland
backend over the X11 one.  This violates the assumption in libgtkui
about th euse of X11, and will eg. cause a crash on keypress in
X11InputMethodContextImplGtk.  The solution is to forbid Wayland using
gdk_set_allowed_backends("x11") prior to gtk_init().

BUG=702876
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2762723003
Cr-Commit-Position: refs/heads/master@{#458218}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d073abb6966b9c2d2ad1033c8a0...
==========

[commit-bot: I haz the power, 2017-03-20 22:59:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5d073abb6966b9c2d2ad1033c8a0...