Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2762613002: MouseEventManager: reset drag state upon detaching. (Closed)

Created:
3 years, 9 months ago by sof
Modified:
3 years, 9 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews, dtapuska+blinkwatch_chromium.org, Navid Zolghadr
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MouseEventManager: reset drag state upon detaching. If an ongoing drag detaches the frame of the dragged element, have the MouseEventManager reset the drag state while handling the detachment from the frame. Otherwise the DragState will retain a reference to the drag source (and its document) for too long, triggering a reported leak on shutdown. R= BUG=703057 Review-Url: https://codereview.chromium.org/2762613002 Cr-Commit-Position: refs/heads/master@{#458116} Committed: https://chromium.googlesource.com/chromium/src/+/f6108b39ff0fa823e85bada2e56dbf89d4f9acad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/input/MouseEventManager.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sof
please take a look.
3 years, 9 months ago (2017-03-20 10:52:39 UTC) #4
dcheng
lgtm
3 years, 9 months ago (2017-03-20 17:43:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762613002/1
3 years, 9 months ago (2017-03-20 17:44:41 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 17:50:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f6108b39ff0fa823e85bada2e56d...

Powered by Google App Engine
This is Rietveld 408576698