Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2762523002:
DevTools: Clarify Service Worker 'Update on reload' location in warning (Closed)
|
Created:
3 years, 9 months ago by jrstanley Modified:
3 years, 9 months ago CC:
blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, shimazu+serviceworker_chromium.org, tzik Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: Clarify Service Worker 'Update on reload' location in warning
A console warning is displayed if 'Update on reload' is checked in the
DevTools Service Worker pane. This CL updates the wording to clarify
where the 'Update on reload' option can be found in DevTools.
BUG=702973
Review-Url: https://codereview.chromium.org/2762523002
Cr-Commit-Position: refs/heads/master@{#458545}
Committed: https://chromium.googlesource.com/chromium/src/+/f1aa486c25eb37a418e32d1f00ef43ed1d98f60a
Patch Set 1 #
Total comments: 1
Patch Set 2 : Simplifies proposed Service Worker 'Update on reload' message #Patch Set 3 : git branch #Messages
Total messages: 20 (10 generated)
james@apphaus.co.uk changed reviewers: + dgozman@chromium.org, horo@chromium.org
PTAL
lgtm https://codereview.chromium.org/2762523002/diff/1/content/browser/service_wor... File content/browser/service_worker/service_worker_version.cc (right): https://codereview.chromium.org/2762523002/diff/1/content/browser/service_wor... content/browser/service_worker/service_worker_version.cc:78: "checked in the DevTools Service Workers pane in the Application panel."; Let's keep it simpler: "... in the DevTools Application panel."
On 2017/03/20 at 18:22:10, dgozman wrote: > lgtm > > https://codereview.chromium.org/2762523002/diff/1/content/browser/service_wor... > File content/browser/service_worker/service_worker_version.cc (right): > > https://codereview.chromium.org/2762523002/diff/1/content/browser/service_wor... > content/browser/service_worker/service_worker_version.cc:78: "checked in the DevTools Service Workers pane in the Application panel."; > Let's keep it simpler: > > "... in the DevTools Application panel." Thanks dgozman, message now simplified as suggested.
lgtm
The CQ bit was checked by james@apphaus.co.uk
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/2762523002/#ps20001 (title: "Simplifies proposed Service Worker 'Update on reload' message")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for AUTHORS: While running git apply --index -p1; error: patch failed: AUTHORS:305 error: AUTHORS: patch does not apply Patch: AUTHORS Index: AUTHORS diff --git a/AUTHORS b/AUTHORS index 88da09b58cce41820b73484c12fa771c9e029c74..bc0399ea8c634140bc22a2cac4bbece681f5d259 100644 --- a/AUTHORS +++ b/AUTHORS @@ -305,6 +305,7 @@ Jake Hendy <me@jakehendy.com> Jakob Weigert <jakob.j.w@googlemail.com> Jakub Machacek <xtreit@gmail.com> James Choi <jchoi42@pha.jhu.edu> +James Stanley <james@apphaus.co.uk> James Vega <vega.james@gmail.com> James Wei <james.wei@intel.com> James Willcox <jwillcox@litl.com>
The CQ bit was checked by james@apphaus.co.uk
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for AUTHORS: While running git apply --index -p1; error: patch failed: AUTHORS:305 error: AUTHORS: patch does not apply Patch: AUTHORS Index: AUTHORS diff --git a/AUTHORS b/AUTHORS index 88da09b58cce41820b73484c12fa771c9e029c74..bc0399ea8c634140bc22a2cac4bbece681f5d259 100644 --- a/AUTHORS +++ b/AUTHORS @@ -305,6 +305,7 @@ Jake Hendy <me@jakehendy.com> Jakob Weigert <jakob.j.w@googlemail.com> Jakub Machacek <xtreit@gmail.com> James Choi <jchoi42@pha.jhu.edu> +James Stanley <james@apphaus.co.uk> James Vega <vega.james@gmail.com> James Wei <james.wei@intel.com> James Willcox <jwillcox@litl.com>
The CQ bit was checked by james@apphaus.co.uk
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org, horo@chromium.org Link to the patchset: https://codereview.chromium.org/2762523002/#ps40001 (title: "git branch")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490125102235170,
"parent_rev": "45035b30f6f1378be80d7c643f46e31f384a7858", "commit_rev":
"f1aa486c25eb37a418e32d1f00ef43ed1d98f60a"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: Clarify Service Worker 'Update on reload' location in warning A console warning is displayed if 'Update on reload' is checked in the DevTools Service Worker pane. This CL updates the wording to clarify where the 'Update on reload' option can be found in DevTools. BUG=702973 ========== to ========== DevTools: Clarify Service Worker 'Update on reload' location in warning A console warning is displayed if 'Update on reload' is checked in the DevTools Service Worker pane. This CL updates the wording to clarify where the 'Update on reload' option can be found in DevTools. BUG=702973 Review-Url: https://codereview.chromium.org/2762523002 Cr-Commit-Position: refs/heads/master@{#458545} Committed: https://chromium.googlesource.com/chromium/src/+/f1aa486c25eb37a418e32d1f00ef... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/f1aa486c25eb37a418e32d1f00ef... |
