Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2762483002: Need to notify the multicol machinery when floats have been laid out. (Closed)

Created:
3 years, 9 months ago by mstensho (USE GERRIT)
Modified:
3 years, 9 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Need to notify the multicol machinery when floats have been laid out. We may have to trigger creation of additional fragmentainer groups, in case there's no regular in-flow content that does it for us. Review-Url: https://codereview.chromium.org/2762483002 Cr-Commit-Position: refs/heads/master@{#457978} Committed: https://chromium.googlesource.com/chromium/src/+/dbe7692563601371957a27bd4162aecae4feb809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/float-margin-at-row-boundary-fixed-multicol-height.html View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/float-margin-at-row-boundary-fixed-multicol-height-expected.html View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mstensho (USE GERRIT)
3 years, 9 months ago (2017-03-18 10:04:46 UTC) #6
eae
OK, LGTM
3 years, 9 months ago (2017-03-18 20:15:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762483002/1
3 years, 9 months ago (2017-03-18 20:19:22 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-18 20:24:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dbe7692563601371957a27bd4162...

Powered by Google App Engine
This is Rietveld 408576698