Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2762443002: DevTools: Only show gutter diff for Network UISourceCodes (Closed)

Created:
3 years, 9 months ago by einbinder
Modified:
3 years, 9 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Only show gutter diff for Network UISourceCodes We don't have a good baseline for unmapped sources from the filesystem BUG=610061 Review-Url: https://codereview.chromium.org/2762443002 Cr-Commit-Position: refs/heads/master@{#458152} Committed: https://chromium.googlesource.com/chromium/src/+/273fceab889606fc42876772d24117ed9fbbe4b9

Patch Set 1 #

Total comments: 2

Patch Set 2 : doc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -8 lines) Patch
M third_party/WebKit/Source/devtools/front_end/source_frame/SourceCodeDiff.js View 1 3 chunks +26 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/UISourceCodeFrame.js View 4 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
einbinder
ptal
3 years, 9 months ago (2017-03-18 02:49:41 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/2762443002/diff/1/third_party/WebKit/Source/devtools/front_end/source_frame/SourceCodeDiff.js File third_party/WebKit/Source/devtools/front_end/source_frame/SourceCodeDiff.js (right): https://codereview.chromium.org/2762443002/diff/1/third_party/WebKit/Source/devtools/front_end/source_frame/SourceCodeDiff.js#newcode24 third_party/WebKit/Source/devtools/front_end/source_frame/SourceCodeDiff.js:24: setUISourceCode(uiSourceCode) { let's add jsdoc
3 years, 9 months ago (2017-03-20 16:49:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762443002/20001
3 years, 9 months ago (2017-03-20 17:41:57 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/273fceab889606fc42876772d24117ed9fbbe4b9
3 years, 9 months ago (2017-03-20 19:43:04 UTC) #9
einbinder
3 years, 9 months ago (2017-03-20 22:38:22 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/2762443002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/source_frame/SourceCodeDiff.js
(right):

https://codereview.chromium.org/2762443002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/source_frame/SourceCodeDiff.js:24:
setUISourceCode(uiSourceCode) {
On 2017/03/20 at 16:49:11, lushnikov wrote:
> let's add jsdoc

Done.

Powered by Google App Engine
This is Rietveld 408576698