MD Settings: move autofill and manage password toggles to their subpages.

MD Settings: move autofill and manage password toggles to their subpages.

Move toggles for autofill and passwords away from the main page, and move it in to their respective subpages.
Also move the extension indicator (and their unit tests) along with the toggle.

BUG=699292
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2762433002
Cr-Commit-Position: refs/heads/master@{#458950}
Committed: https://chromium.googlesource.com/chromium/src/+/90711039262bcbbc20c28c6b6d79ce2d73aa5e3c

[scottchen, 2017-03-18 01:42:20]

Description was changed from

==========
MD Settings: move autofill and manage password toggles to their subpages.

Move toggles for autofill and passwords away from the main page, and move it in
to their respective subpages.
Also move the extension indicator (and their unit tests) along with the toggle.

BUG=699292
==========

to

==========
MD Settings: move autofill and manage password toggles to their subpages.

Move toggles for autofill and passwords away from the main page, and move it in
to their respective subpages.
Also move the extension indicator (and their unit tests) along with the toggle.

BUG=699292
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-03-18 01:46:19]

scottchen@chromium.org changed reviewers:
+ dbeam@chromium.org

[scottchen, 2017-03-18 01:46:28]

The CQ bit was checked by scottchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-18 01:46:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 02:44:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 02:44:41]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[scottchen, 2017-03-20 19:54:57]

This CL is ready for review.

Added conditional styling according to spec: 
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pag...
(exception: confirmed with designer, OFF should be using paper-grey-600, not
#333 as spec indicated)

Before/after ss for autofill section: http://imgur.com/a/xGzk4
Before/after ss for password section: http://imgur.com/a/L3hbu
Video capture of the toggles working in separate windows:
https://drive.google.com/open?id=0ByIc0PEad7DmeklPMDRXd1FVNlk

[scottchen, 2017-03-20 23:38:17]

The CQ bit was checked by scottchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 23:38:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 01:15:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 01:15:34]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-03-21 07:02:52]

lgtm

https://codereview.chromium.org/2762433002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
(right):

https://codereview.chromium.org/2762433002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js:439:
return toggleValue ? onString : offString;
this could also be

return toggleValue ? this.i18n('toggleOn') : this.i18n('toggleOff')

with less stuff in the binding, but whatevs

[scottchen, 2017-03-21 19:15:54]

The CQ bit was checked by scottchen@chromium.org to run a CQ dry run

[scottchen, 2017-03-21 19:16:22]

dbeam@ I uploaded another patch based on your recommendation (and also added it
to passwords_section.js). Please re-lg :)

https://codereview.chromium.org/2762433002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
(right):

https://codereview.chromium.org/2762433002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js:439:
return toggleValue ? onString : offString;
On 2017/03/21 07:02:52, Dan Beam wrote:
> this could also be
> 
> return toggleValue ? this.i18n('toggleOn') : this.i18n('toggleOff')
> 
> with less stuff in the binding, but whatevs

Dave mentioned that other places in the code that's doing this was using
$18nPolymer so I copied it. Didn't know this.i18n() is a thing though, much
simpler IMO.

[commit-bot: I haz the power, 2017-03-21 19:16:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 20:28:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 20:28:03]

Dry run: This issue passed the CQ dry run.

[scottchen, 2017-03-22 20:41:54]

The CQ bit was checked by scottchen@chromium.org

[scottchen, 2017-03-22 20:41:54]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2762433002/#ps80001
(title: "use this.i18n instead")

[commit-bot: I haz the power, 2017-03-22 20:42:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 21:45:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 21:45:36]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scottchen, 2017-03-23 00:14:16]

The CQ bit was checked by scottchen@chromium.org

[commit-bot: I haz the power, 2017-03-23 00:15:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 00:23:28]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490228056791150,
"parent_rev": "32e0bf3ee63c3798f51c2ecefb941195326cc0da", "commit_rev":
"90711039262bcbbc20c28c6b6d79ce2d73aa5e3c"}

[commit-bot: I haz the power, 2017-03-23 00:24:41]

Description was changed from

==========
MD Settings: move autofill and manage password toggles to their subpages.

Move toggles for autofill and passwords away from the main page, and move it in
to their respective subpages.
Also move the extension indicator (and their unit tests) along with the toggle.

BUG=699292
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: move autofill and manage password toggles to their subpages.

Move toggles for autofill and passwords away from the main page, and move it in
to their respective subpages.
Also move the extension indicator (and their unit tests) along with the toggle.

BUG=699292
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2762433002
Cr-Commit-Position: refs/heads/master@{#458950}
Committed:
https://chromium.googlesource.com/chromium/src/+/90711039262bcbbc20c28c6b6d79...
==========

[commit-bot: I haz the power, 2017-03-23 00:24:42]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/90711039262bcbbc20c28c6b6d79...