Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2762393002: Add more commentsin cros_component_installer (Closed)

Created:
3 years, 9 months ago by xiaochu
Modified:
3 years, 8 months ago
Reviewers:
waffles, Sorin Jianu
CC:
chromium-reviews, adlr
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more commentsin cros_component_installer Added a concrete example in comments on how to call Chrome OS Component API. BUG=690521 TEST=None Review-Url: https://codereview.chromium.org/2762393002 Cr-Commit-Position: refs/heads/master@{#460506} Committed: https://chromium.googlesource.com/chromium/src/+/b6658855c95156252b627ffee77f31699041a69f

Patch Set 1 #

Patch Set 2 : add one empty line to improve readability #

Patch Set 3 : fix alignment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -6 lines) Patch
M chrome/browser/component_updater/cros_component_installer.h View 1 2 1 chunk +48 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
xiaochu
On 2017/03/21 22:41:19, xiaochu wrote: > mailto:xiaochu@chromium.org changed reviewers: > + mailto:sorin@chromium.org, mailto:waffles@chromium.org can you ...
3 years, 9 months ago (2017-03-27 21:50:10 UTC) #3
Sorin Jianu
lgtm Thank you!
3 years, 8 months ago (2017-03-29 16:38:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762393002/40001
3 years, 8 months ago (2017-03-29 19:52:12 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 20:04:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b6658855c95156252b627ffee77f...

Powered by Google App Engine
This is Rietveld 408576698