services/service_manager/public/tools/test/service_test.gni - Issue 2762333003: Pref service: add a factory to create the client lib

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/service_manager/public/tools/test/service_test.gni

Issue 2762333003: Pref service: add a factory to create the client lib (Closed)

Patch Set: Address more review comments from sammc@ Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/service_manager/public/tools/test/service_test.gni

diff --git a/services/service_manager/public/tools/test/service_test.gni b/services/service_manager/public/tools/test/service_test.gni

index dd36135838c64d9ffcb435b6fd256c0f323c63e8..91369833df7fb44b2b25da2e553c79144ab81873 100644

--- a/services/service_manager/public/tools/test/service_test.gni

+++ b/services/service_manager/public/tools/test/service_test.gni

@@ -31,6 +31,7 @@ template("service_test") {

}

catalog_cpp_source(catalog_source_target) {

+ testonly = true

catalog = invoker.catalog

generated_function_name = "service_manager::test::CreateTestCatalog"

}