Pref service: add a factory to create the client lib

services/preferences/public/cpp/pref_service_factory.h

Index: services/preferences/public/cpp/pref_service_factory.h
diff --git a/services/preferences/public/cpp/pref_service_factory.h b/services/preferences/public/cpp/pref_service_factory.h
new file mode 100644
index 0000000000000000000000000000000000000000..0926b06f822eed644b76f6e10e3f0735c9c0680d
--- /dev/null
+++ b/services/preferences/public/cpp/pref_service_factory.h
@@ -0,0 +1,43 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// This provides a way for any service to connect to the pref service to access
+// the application's current preferences.
+
+// Access is provided through a synchronous interface, exposed using the
+// |PrefService| class.
+
+#ifndef SERVICES_PREFERENCES_PUBLIC_CPP_PREF_SERVICE_FACTORY_H_

[Ken Rockot(use gerrit already), 2017/03/22 06:21:01]

I have to say it's kind of a bummer that the pref service's client library has a
"pref service factory". I realize why this is true (different meaning of
"PrefService"), and I'm not asking you to change it because it's unfortunately
correct, but... ew. Just ew.

[tibell, 2017/03/22 06:26:12]

I know. I know. :) When this service has taken over the world I will still be
thinking of a better way of naming this. All I can say is that will give it a
better name if I ever come up with one. :)

+#define SERVICES_PREFERENCES_PUBLIC_CPP_PREF_SERVICE_FACTORY_H_
+
+#include <memory>
+
+#include "base/callback.h"
+
+class PrefRegistry;
+class PrefService;
+
+namespace service_manager {
+class Connector;
+}
+
+namespace prefs {
+
+// Note that |PrefService| might not be fully initialized yet and thus you need
+// to call |AddPrefInitObserver| on it before using it. Passed |nullptr| on
+// failure.
+using ConnectCallback = base::Callback<void(std::unique_ptr<::PrefService>)>;
+
+// Create a |PrefService| object acting as a client library for the pref
+// service, by connecting to the service using |connector|. Connecting is
+// asynchronous and |callback| will be called when it has been established. All
+// preferences that will be accessed need to be registered in |pref_registry|
+// first.
+void ConnectToPrefService(service_manager::Connector* connector,
+                          scoped_refptr<PrefRegistry> pref_registry,
+                          const ConnectCallback& callback);
+
+}  // namespace prefs
+
+#endif  // SERVICES_PREFERENCES_PUBLIC_CPP_PREF_SERVICE_FACTORY_H_