Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1809)

Unified Diff: services/preferences/BUILD.gn

Issue 2762333003: Pref service: add a factory to create the client lib (Closed)
Patch Set: Address more review comments from sammc@ Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/preferences/BUILD.gn
diff --git a/services/preferences/BUILD.gn b/services/preferences/BUILD.gn
index 524b6bd8a28ed2f6b959f0688e8bc833f017b029..bdf33128c57df917c9bbdffa9504ed4bf3f88795 100644
--- a/services/preferences/BUILD.gn
+++ b/services/preferences/BUILD.gn
@@ -2,16 +2,10 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//services/catalog/public/tools/catalog.gni")
import("//services/service_manager/public/service_manifest.gni")
import("//testing/test.gni")
-group("tests") {
- testonly = true
- deps = [
- ":preferences_unittests",
- ]
-}
-
service_manifest("manifest") {
name = "preferences2"
source = "manifest.json"
@@ -32,21 +26,37 @@ source_set("preferences") {
]
}
-test("preferences_unittests") {
+source_set("tests") {
+ testonly = true
deps = [
":preferences",
"//base",
"//base/test:test_support",
"//components/prefs:test_support",
- "//mojo/edk/test:run_all_unittests",
"//mojo/public/cpp/bindings:bindings",
"//services/preferences/public/cpp",
"//services/preferences/public/cpp/tests",
"//services/preferences/public/interfaces",
+ "//services/service_manager/public/cpp",
"//testing/gmock",
"//testing/gtest",
]
sources = [
"persistent_pref_store_impl_unittest.cc",
]
+ if (!is_ios) {
+ sources += [ "pref_service_factory_unittest.cc" ]
+ deps += [ "//services/service_manager/public/cpp:service_test_support" ]
+ }
+}
+
+service_manifest("unittest_manifest") {
+ name = "prefs_unittests"
+ source = "unittest_manifest.json"
+ packaged_services = [ ":manifest" ]
+}
+
+catalog("tests_catalog") {
+ testonly = true
+ embedded_services = [ ":unittest_manifest" ]
}

Powered by Google App Engine
This is Rietveld 408576698