runtime/vm/object.cc - Issue 2762313003: Dwarf tools interpret line number table pc's as start boundries instead of end boundries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 2762313003: Dwarf tools interpret line number table pc's as start boundries instead of end boundries. (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index 0c3cdba4b2b28511728297bc395ce6f389c8eb6b..d62c9e96dafbf17533b7175e549f3584b71b885a 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -9150,6 +9150,9 @@ void Script::SetLocationOffset(intptr_t line_offset,

// position that could be part of a stack trace.

intptr_t Script::GetTokenLineUsingLineStarts(

TokenPosition target_token_pos) const {

+ if (target_token_pos.IsNoSource()) {

+ return 0;

+ }

Zone* zone = Thread::Current()->zone();

Array& line_starts_array = Array::Handle(zone, line_starts());

Smi& token_pos = Smi::Handle(zone);

« no previous file with comments | « runtime/vm/dwarf.cc ('k') | tests/standalone/dwarf_stack_trace_test.dart » ('j') | no next file with comments »