Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: runtime/vm/dwarf.cc

Issue 2762313003: Dwarf tools interpret line number table pc's as start boundries instead of end boundries. (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dwarf.cc
diff --git a/runtime/vm/dwarf.cc b/runtime/vm/dwarf.cc
index b2e24981a4d6eee261766b359409916dd679a773..a38f74e4e80a9a447616c6c0fc04a236f5a43aaa 100644
--- a/runtime/vm/dwarf.cc
+++ b/runtime/vm/dwarf.cc
@@ -587,7 +587,10 @@ void Dwarf::WriteLines() {
previous_line = line;
}
- // 3. Update LNP pc.
+ // 3. Emit LNP row.
+ u1(DW_LNS_copy);
+
+ // 4. Update LNP pc.
if (previous_code_index == -1) {
// This variant is relocatable.
u1(0); // This is an extended opcode
@@ -601,10 +604,6 @@ void Dwarf::WriteLines() {
}
previous_code_index = i;
previous_pc_offset = current_pc_offset;
-
- // 4. Emit LNP row.
- u1(DW_LNS_copy);
-
break;
}
case CodeSourceMapBuilder::kPushFunction: {
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698