Dwarf tools interpret line number table pc's as start boundries instead of end boundries.

Dwarf tools interpret line number table pc's as start boundries instead of end boundries.

Put kNoSourcePosition on line 0 instead of line 1.

Closes #28785

R=fschneider@google.com, johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/7589236f45c23e8397cfe9be6f4031d61a14c702

[rmacnak, 2017-03-21 20:40:25]

Description was changed from

==========
Dwarf tools interpret line number table pc's as start boundries instead of end
boundries.
==========

to

==========
Dwarf tools interpret line number table pc's as start boundries instead of end
boundries.

Put kNoSourcePosition on line 0 instead of line 1.
==========

[rmacnak, 2017-03-21 20:41:10]

rmacnak@google.com changed reviewers:
+ fschneider@google.com, johnmccutchan@google.com

[Cutch, 2017-03-21 20:44:25]

LGTM. Anyway to write tests for this stuff?

[Florian Schneider, 2017-03-21 20:47:50]

lgtm

[rmacnak, 2017-03-22 00:13:24]

On 2017/03/21 20:44:25, Cutch wrote:
> LGTM. Anyway to write tests for this stuff?

Added a test that attempts to use addr2line on a locally-caught stack trace.
This comes with weakening of checks that --dwarf-stack-traces is being used in
an appropriate context because it isn't currently possible to match on using
blobs or dylibs in the status files.

[rmacnak, 2017-03-22 00:13:42]

Description was changed from

==========
Dwarf tools interpret line number table pc's as start boundries instead of end
boundries.

Put kNoSourcePosition on line 0 instead of line 1.
==========

to

==========
Dwarf tools interpret line number table pc's as start boundries instead of end
boundries.

Put kNoSourcePosition on line 0 instead of line 1.

Closes #28785
==========

[Cutch, 2017-03-22 14:04:37]

LGTM w/c

https://codereview.chromium.org/2762313003/diff/20001/tests/standalone/dwarf_...
File tests/standalone/dwarf_stack_trace_test.dart (right):

https://codereview.chromium.org/2762313003/diff/20001/tests/standalone/dwarf_...
tests/standalone/dwarf_stack_trace_test.dart:38: print("Skipping test because
'file' is not present");
you should fail here and update the status file accordingly.

https://codereview.chromium.org/2762313003/diff/20001/tests/standalone/dwarf_...
tests/standalone/dwarf_stack_trace_test.dart:44: print("Skipping test because
'addr2line' is not present");
you should fail here and update the status file accordingly.

https://codereview.chromium.org/2762313003/diff/20001/tests/standalone/dwarf_...
tests/standalone/dwarf_stack_trace_test.dart:56: print("Skipping test because we
are not running from a dylib");
you should fail here and update the status file accordingly.

https://codereview.chromium.org/2762313003/diff/20001/tests/standalone/dwarf_...
tests/standalone/dwarf_stack_trace_test.dart:82: var symbolizedLines =
symbolizedStack.toString().split("\n");
use stringContainsInOrder

expect(symbolizedStack.toString(), stringContainsInOrder([
'bar',
'dwarf_stack_trace_test.dart:12',
...
           ]));

[rmacnak, 2017-03-22 17:28:15]

Updated the test to fail if a Linux system lacks file or addr2line.

https://codereview.chromium.org/2762313003/diff/20001/tests/standalone/dwarf_...
File tests/standalone/dwarf_stack_trace_test.dart (right):

https://codereview.chromium.org/2762313003/diff/20001/tests/standalone/dwarf_...
tests/standalone/dwarf_stack_trace_test.dart:82: var symbolizedLines =
symbolizedStack.toString().split("\n");
On 2017/03/22 14:04:37, Cutch wrote:
> use stringContainsInOrder
> 
> expect(symbolizedStack.toString(), stringContainsInOrder([
> 'bar',
> 'dwarf_stack_trace_test.dart:12',
> ...
>            ]));

Done.

[rmacnak, 2017-03-22 17:30:12]

Description was changed from

==========
Dwarf tools interpret line number table pc's as start boundries instead of end
boundries.

Put kNoSourcePosition on line 0 instead of line 1.

Closes #28785
==========

to

==========
Dwarf tools interpret line number table pc's as start boundries instead of end
boundries.

Put kNoSourcePosition on line 0 instead of line 1.

Closes #28785

R=fschneider@google.com, johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7589236f45c23e8397cfe9be6f4031d61a14c702
==========

[rmacnak, 2017-03-22 17:30:13]

Committed patchset #3 (id:40001) manually as
7589236f45c23e8397cfe9be6f4031d61a14c702.