Revert "Revert of [Android] Do not restore NTPs from disk unless they are selected. (patchset #3 id…

Revert "Revert of [Android] Do not restore NTPs from disk unless they are selected. (patchset #3 id:40001 of https://codereview.chromium.org/2757013002/ )"

This reverts commit 28865543d686d93a737842b56b623f019af8ddac.

I believe it to be an issue where the bot is building with java 1.7 and
locally I am building with 1.8.  In 1.8, the cast is not required from
isNull(), but that is not the case with 1.7 (according to the interwebs).

TBR=dfalcantara@chromium.org
BUG=702762
Review-Url: https://codereview.chromium.org/2762313002
Cr-Commit-Position: refs/heads/master@{#458578}
Committed: https://chromium.googlesource.com/chromium/src/+/61ea7ade8321d66dccb81984581e379adcb0aa42

[Ted C, 2017-03-21 20:25:10]

Description was changed from

==========
Revert "Revert of [Android] Do not restore NTPs from disk unless they are
selected. (patchset #3 id:40001 of https://codereview.chromium.org/2757013002/
)"

This reverts commit 28865543d686d93a737842b56b623f019af8ddac.

I believe it to be an issue where the bot is building with java 1.7 and
locally I am building with 1.8.  In 1.8, the cast is not required from
isNull(), but that is not the case with 1.7 (according to the interwebs).

BUG=702762
==========

to

==========
Revert "Revert of [Android] Do not restore NTPs from disk unless they are
selected. (patchset #3 id:40001 of https://codereview.chromium.org/2757013002/
)"

This reverts commit 28865543d686d93a737842b56b623f019af8ddac.

I believe it to be an issue where the bot is building with java 1.7 and
locally I am building with 1.8.  In 1.8, the cast is not required from
isNull(), but that is not the case with 1.7 (according to the interwebs).

TBR=dfalcantara@chromium.org
BUG=702762
==========

[Ted C, 2017-03-21 20:25:10]

tedchoc@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Ted C, 2017-03-21 20:25:14]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2017-03-21 20:26:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ted C, 2017-03-21 20:26:31]

https://codereview.chromium.org/2762313002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreUnitTest.java
(right):

https://codereview.chromium.org/2762313002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreUnitTest.java:175:
argThat(paramsMatcher), eq(TabLaunchType.FROM_RESTORE), (Tab) isNull()))
this line (and the other isNull() below) are where I added the (Tab) cast to
hopefully appease the older java version on the failing bot.  I can't even get
it to build with 1.7 locally anymore, so I am crossing my fingers here :-/

[commit-bot: I haz the power, 2017-03-21 20:50:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 20:50:56]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ted C, 2017-03-21 21:14:17]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2017-03-21 21:14:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 22:17:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490130857718860, "parent_rev":
"937b793358b743d046d2038b9fe979056f660465", "commit_rev":
"61ea7ade8321d66dccb81984581e379adcb0aa42"}

[commit-bot: I haz the power, 2017-03-21 22:17:54]

Description was changed from

==========
Revert "Revert of [Android] Do not restore NTPs from disk unless they are
selected. (patchset #3 id:40001 of https://codereview.chromium.org/2757013002/
)"

This reverts commit 28865543d686d93a737842b56b623f019af8ddac.

I believe it to be an issue where the bot is building with java 1.7 and
locally I am building with 1.8.  In 1.8, the cast is not required from
isNull(), but that is not the case with 1.7 (according to the interwebs).

TBR=dfalcantara@chromium.org
BUG=702762
==========

to

==========
Revert "Revert of [Android] Do not restore NTPs from disk unless they are
selected. (patchset #3 id:40001 of https://codereview.chromium.org/2757013002/
)"

This reverts commit 28865543d686d93a737842b56b623f019af8ddac.

I believe it to be an issue where the bot is building with java 1.7 and
locally I am building with 1.8.  In 1.8, the cast is not required from
isNull(), but that is not the case with 1.7 (according to the interwebs).

TBR=dfalcantara@chromium.org
BUG=702762

Review-Url: https://codereview.chromium.org/2762313002
Cr-Commit-Position: refs/heads/master@{#458578}
Committed:
https://chromium.googlesource.com/chromium/src/+/61ea7ade8321d66dccb81984581e...
==========

[commit-bot: I haz the power, 2017-03-21 22:17:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/61ea7ade8321d66dccb81984581e...