Use canonical names for some name-based lookup.

Use canonical names for some name-based lookup.

For compiling the platform libraries separately and for hot reload, we
will not link canonical names of Kernel libraries, classes, and
members to their Kernel definitions.  Those definitions will not be
persistent.

As a first step, change name-based lookup of libraries and classes to
be be based on the canonical name instead of the Kernel definition.

BUG=
R=jensj@google.com, kustermann@google.com

Committed: https://github.com/dart-lang/sdk/commit/a15b8c49ea195345f542d4efbe8d6dd29268d030
Committed: https://github.com/dart-lang/sdk/commit/d715611c03a3bf94ad63e48c268dbc6ef1ead1da

[Kevin Millikin (Google), 2017-03-21 15:03:43]

kmillikin@google.com changed reviewers:
+ asgerf@google.com, kustermann@google.com

[kustermann, 2017-03-23 10:43:18]

LGTM

https://codereview.chromium.org/2762213002/diff/1/runtime/vm/kernel.h
File runtime/vm/kernel.h (right):

https://codereview.chromium.org/2762213002/diff/1/runtime/vm/kernel.h#newcode...
runtime/vm/kernel.h:2537: }
As a safeguard, I think we should get rid of these old getters! (to prevent any
old or new code accidentally using it)

[Kevin Millikin (Google), 2017-03-23 11:15:52]

https://codereview.chromium.org/2762213002/diff/1/runtime/vm/kernel.h
File runtime/vm/kernel.h (right):

https://codereview.chromium.org/2762213002/diff/1/runtime/vm/kernel.h#newcode...
runtime/vm/kernel.h:2537: }
On 2017/03/23 10:43:18, kustermann wrote:
> As a safeguard, I think we should get rid of these old getters! (to prevent
any
> old or new code accidentally using it)

I agree.

I plan to get rid of the definition from the CanonicalName class and at that
point they will not work.  If we have code that really needs them we will do
something like a map on the side.

[Kevin Millikin (Google), 2017-03-23 11:24:11]

Description was changed from

==========
Use canonical names for some name-based lookup.

For compiling the platform libraries separately and for hot reload, we
will not link canonical names of Kernel libraries, classes, and
members to their Kernel definitions.  Those definitions will not be
persistent.

As a first step, change name-based lookup of libraries and classes to
be be based on the canonical name instead of the Kernel definition.

BUG=
==========

to

==========
Use canonical names for some name-based lookup.

For compiling the platform libraries separately and for hot reload, we
will not link canonical names of Kernel libraries, classes, and
members to their Kernel definitions.  Those definitions will not be
persistent.

As a first step, change name-based lookup of libraries and classes to
be be based on the canonical name instead of the Kernel definition.

BUG=
R=kustermann@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a15b8c49ea195345f542d4efbe8d6dd29268d030
==========

[Kevin Millikin (Google), 2017-03-23 11:24:14]

Committed patchset #1 (id:1) manually as
a15b8c49ea195345f542d4efbe8d6dd29268d030 (presubmit successful).

[Kevin Millikin (Google), 2017-03-24 11:38:20]

kmillikin@google.com changed reviewers:
+ jensj@google.com

[Kevin Millikin (Google), 2017-03-24 11:38:20]

The problem is that we can't get the library name from its canonical name. 
Instead, set the library name in ReadLibrary (when it's members are set up) and
not in LoadLibrary (when it might be first created).

[Kevin Millikin (Google), 2017-03-24 14:58:10]

Description was changed from

==========
Use canonical names for some name-based lookup.

For compiling the platform libraries separately and for hot reload, we
will not link canonical names of Kernel libraries, classes, and
members to their Kernel definitions.  Those definitions will not be
persistent.

As a first step, change name-based lookup of libraries and classes to
be be based on the canonical name instead of the Kernel definition.

BUG=
R=kustermann@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a15b8c49ea195345f542d4efbe8d6dd29268d030
==========

to

==========
Use canonical names for some name-based lookup.

For compiling the platform libraries separately and for hot reload, we
will not link canonical names of Kernel libraries, classes, and
members to their Kernel definitions.  Those definitions will not be
persistent.

As a first step, change name-based lookup of libraries and classes to
be be based on the canonical name instead of the Kernel definition.

BUG=
R=kustermann@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a15b8c49ea195345f542d4efbe8d6dd29268d030
==========

[Kevin Millikin (Google), 2017-03-24 14:58:46]

Patch set #2 contains the fixes (and a merge :( ).  Please take a look.

[jensj, 2017-03-27 06:30:22]

lgtm

[Kevin Millikin (Google), 2017-03-27 10:14:57]

Description was changed from

==========
Use canonical names for some name-based lookup.

For compiling the platform libraries separately and for hot reload, we
will not link canonical names of Kernel libraries, classes, and
members to their Kernel definitions.  Those definitions will not be
persistent.

As a first step, change name-based lookup of libraries and classes to
be be based on the canonical name instead of the Kernel definition.

BUG=
R=kustermann@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a15b8c49ea195345f542d4efbe8d6dd29268d030
==========

to

==========
Use canonical names for some name-based lookup.

For compiling the platform libraries separately and for hot reload, we
will not link canonical names of Kernel libraries, classes, and
members to their Kernel definitions.  Those definitions will not be
persistent.

As a first step, change name-based lookup of libraries and classes to
be be based on the canonical name instead of the Kernel definition.

BUG=
R=jensj@google.com, kustermann@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a15b8c49ea195345f542d4efbe8d6dd29268d030
Committed:
https://github.com/dart-lang/sdk/commit/d715611c03a3bf94ad63e48c268dbc6ef1ead1da
==========

[Kevin Millikin (Google), 2017-03-27 10:14:59]

Committed patchset #2 (id:20001) manually as
d715611c03a3bf94ad63e48c268dbc6ef1ead1da (presubmit successful).