Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: runtime/vm/kernel_reader.h

Issue 2762213002: Use canonical names for some name-based lookup. (Closed)
Patch Set: Do not use the import URI to name libraries Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/kernel.h ('k') | runtime/vm/kernel_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_reader.h
diff --git a/runtime/vm/kernel_reader.h b/runtime/vm/kernel_reader.h
index 092b90d3702c9cfda1f11eaf51d54cac0a307300..5912c3694d2e9dd3b4e37a2837ee8ebb103644d9 100644
--- a/runtime/vm/kernel_reader.h
+++ b/runtime/vm/kernel_reader.h
@@ -23,8 +23,8 @@ class BuildingTranslationHelper : public TranslationHelper {
: TranslationHelper(thread), reader_(reader) {}
virtual ~BuildingTranslationHelper() {}
- virtual RawLibrary* LookupLibraryByKernelLibrary(Library* library);
- virtual RawClass* LookupClassByKernelClass(Class* klass);
+ virtual RawLibrary* LookupLibraryByKernelLibrary(CanonicalName* library);
+ virtual RawClass* LookupClassByKernelClass(CanonicalName* klass);
private:
KernelReader* reader_;
@@ -92,8 +92,8 @@ class KernelReader {
void SetupFieldAccessorFunction(const dart::Class& klass,
const dart::Function& function);
- dart::Library& LookupLibrary(Library* library);
- dart::Class& LookupClass(Class* klass);
+ dart::Library& LookupLibrary(CanonicalName* library);
+ dart::Class& LookupClass(CanonicalName* klass);
dart::RawFunction::Kind GetFunctionType(Procedure* kernel_procedure);
@@ -107,8 +107,8 @@ class KernelReader {
BuildingTranslationHelper translation_helper_;
DartTypeTranslator type_translator_;
- Mapping<Library, dart::Library> libraries_;
- Mapping<Class, dart::Class> classes_;
+ Mapping<CanonicalName, dart::Library> libraries_;
+ Mapping<CanonicalName, dart::Class> classes_;
};
} // namespace kernel
« no previous file with comments | « runtime/vm/kernel.h ('k') | runtime/vm/kernel_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698