Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2762173003: Remove IsNewProfileManagement and EnableNewProfileManagementForTesting (Closed)

Created:
3 years, 9 months ago by msarda
Modified:
3 years, 9 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org, mac-reviews_chromium.org, Matt Giuca, oshima+watch_chromium.org, rginda+watch_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove IsNewProfileManagement and EnableNewProfileManagementForTesting BUG=703179 Review-Url: https://codereview.chromium.org/2762173003 Cr-Commit-Position: refs/heads/master@{#459036} Committed: https://chromium.googlesource.com/chromium/src/+/ca0f6132d435767127a2b287cce8912d81296678

Patch Set 1 : Remove EnableNewProfileManagementForTesting #

Patch Set 2 : Ready for review #

Patch Set 3 : Rebase #

Patch Set 4 : Fix compile (add back an include) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -69 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/app_controller_mac_browsertest.mm View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/profiles/profile_list_chromeos.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_downloader.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/profiles/profile_window.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profiles_state.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_disabled.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm View 1 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/signin/core/browser/about_signin_internals.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/signin/core/common/profile_management_switches.h View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M components/signin/core/common/profile_management_switches.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 28 (18 generated)
msarda
Please take a look.
3 years, 9 months ago (2017-03-21 16:53:19 UTC) #7
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2017-03-22 10:00:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762173003/40001
3 years, 9 months ago (2017-03-22 13:09:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/175076) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-22 13:11:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762173003/60001
3 years, 9 months ago (2017-03-22 15:04:22 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/261135)
3 years, 9 months ago (2017-03-22 15:22:03 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762173003/80001
3 years, 9 months ago (2017-03-22 17:04:34 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/414180)
3 years, 9 months ago (2017-03-22 18:09:01 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762173003/80001
3 years, 9 months ago (2017-03-23 09:40:55 UTC) #25
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 10:07:37 UTC) #28
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/ca0f6132d435767127a2b287cce8...

Powered by Google App Engine
This is Rietveld 408576698