Content test launcher: Initialize globals to nullptr

Content test launcher: Initialize globals to nullptr

g_launcher_delegate and g_params in content/public/test/test_launcher.cc
were both uninitialized. This sometimes caused the
DCHECK(!g_launcher_delegate) in LaunchTests to fail, since the
uninitialized memory wasn't necessarily zero!

In particular, this has caused significant flakiness in
content_browsertests on Lollipop Tablet Tester starting from
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/7234
Presumably something changed between
6019ce8862dbf9acbc4b2a6b42849657002f3b41 {#458098} and
f6108b39ff0fa823e85bada2e56dbf89d4f9acad {#458116} which happens to
alter the uninitialized memory.

BUG=none
NOTRY=true
SKIPTREECHECKS=true
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2762173002
Cr-Commit-Position: refs/heads/master@{#458396}
Committed: https://chromium.googlesource.com/chromium/src/+/f41cd022151ab7afea8ccbf411132984965cd6b9

[johnme, 2017-03-21 13:56:27]

Description was changed from

==========
Content test launcher: Initialize globals to nullptr

g_launcher_delegate and g_params in content/public/test/test_launcher.cc
were both uninitialized. This sometimes caused the
DCHECK(!g_launcher_delegate) in LaunchTests to fail, since the
uninitialized memory wasn't necessarily zero!

In particular, this has caused significant flakiness in
content_browsertests on Lollipop Tablet Tester starting from
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Te...
Presumably something changed between
6019ce8862dbf9acbc4b2a6b42849657002f3b41 {#458098} and
f6108b39ff0fa823e85bada2e56dbf89d4f9acad {#458116} which happens to
alter the uninitialized memory.

BUG=none
==========

to

==========
Content test launcher: Initialize globals to nullptr

g_launcher_delegate and g_params in content/public/test/test_launcher.cc
were both uninitialized. This sometimes caused the
DCHECK(!g_launcher_delegate) in LaunchTests to fail, since the
uninitialized memory wasn't necessarily zero!

In particular, this has caused significant flakiness in
content_browsertests on Lollipop Tablet Tester starting from
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Te...
Presumably something changed between
6019ce8862dbf9acbc4b2a6b42849657002f3b41 {#458098} and
f6108b39ff0fa823e85bada2e56dbf89d4f9acad {#458116} which happens to
alter the uninitialized memory.

BUG=none
NOTRY=true
SKIPTREECHECKS=true
TBR=jam@chromium.org
==========

[johnme, 2017-03-21 13:56:28]

johnme@chromium.org changed reviewers:
+ jam@chromium.org

[johnme, 2017-03-21 13:56:35]

The CQ bit was checked by johnme@chromium.org

[commit-bot: I haz the power, 2017-03-21 13:56:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[johnme, 2017-03-21 13:59:54]

The CQ bit was unchecked by johnme@chromium.org

[johnme, 2017-03-21 14:01:24]

The CQ bit was checked by johnme@chromium.org

[commit-bot: I haz the power, 2017-03-21 14:01:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 14:05:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490104884103150, "parent_rev":
"d2908c0a13e525bffd180f9aa541078de4b9df8e", "commit_rev":
"f41cd022151ab7afea8ccbf411132984965cd6b9"}

[commit-bot: I haz the power, 2017-03-21 14:06:10]

Description was changed from

==========
Content test launcher: Initialize globals to nullptr

g_launcher_delegate and g_params in content/public/test/test_launcher.cc
were both uninitialized. This sometimes caused the
DCHECK(!g_launcher_delegate) in LaunchTests to fail, since the
uninitialized memory wasn't necessarily zero!

In particular, this has caused significant flakiness in
content_browsertests on Lollipop Tablet Tester starting from
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Te...
Presumably something changed between
6019ce8862dbf9acbc4b2a6b42849657002f3b41 {#458098} and
f6108b39ff0fa823e85bada2e56dbf89d4f9acad {#458116} which happens to
alter the uninitialized memory.

BUG=none
NOTRY=true
SKIPTREECHECKS=true
TBR=jam@chromium.org
==========

to

==========
Content test launcher: Initialize globals to nullptr

g_launcher_delegate and g_params in content/public/test/test_launcher.cc
were both uninitialized. This sometimes caused the
DCHECK(!g_launcher_delegate) in LaunchTests to fail, since the
uninitialized memory wasn't necessarily zero!

In particular, this has caused significant flakiness in
content_browsertests on Lollipop Tablet Tester starting from
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Te...
Presumably something changed between
6019ce8862dbf9acbc4b2a6b42849657002f3b41 {#458098} and
f6108b39ff0fa823e85bada2e56dbf89d4f9acad {#458116} which happens to
alter the uninitialized memory.

BUG=none
NOTRY=true
SKIPTREECHECKS=true
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2762173002
Cr-Commit-Position: refs/heads/master@{#458396}
Committed:
https://chromium.googlesource.com/chromium/src/+/f41cd022151ab7afea8ccbf41113...
==========

[commit-bot: I haz the power, 2017-03-21 14:06:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f41cd022151ab7afea8ccbf41113...

[johnme, 2017-03-21 14:16:28]

In hindsight this shouldn't make a difference, as these variables have static
storage duration, so should theoretically already be getting zero-initialized.

But I can't see any other explanation for the following DCHECK failures:
[FATAL:test_launcher.cc(487)] Check failed: !g_launcher_delegate.

Since g_launcher_delegate is only set by LaunchTests, which is only called from
main, and it seems unlikely that main is being called multiple times.