cc: LayerTreeHostImpl uses element id to tick animations

third_party/WebKit/Source/platform/graphics/CompositorMutableState.cpp

Index: third_party/WebKit/Source/platform/graphics/CompositorMutableState.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/CompositorMutableState.cpp b/third_party/WebKit/Source/platform/graphics/CompositorMutableState.cpp
index 87c1ea20661c2dfbf718f444623743a0a1b67b24..468dac1f0309c083217961bdd4c4b9379db97fba 100644
--- a/third_party/WebKit/Source/platform/graphics/CompositorMutableState.cpp
+++ b/third_party/WebKit/Source/platform/graphics/CompositorMutableState.cpp
@@ -23,10 +23,8 @@ double CompositorMutableState::opacity() const {
 void CompositorMutableState::setOpacity(double opacity) {
   if (!m_mainLayer)
     return;
-  m_mainLayer->layer_tree_impl()
-      ->property_trees()
-      ->effect_tree.OnOpacityAnimated(opacity, m_mainLayer->effect_tree_index(),
-                                      m_mainLayer->layer_tree_impl());
+  m_mainLayer->layer_tree_impl()->SetOpacityMutated(m_mainLayer->element_id(),

[wkorman, 2017/03/27 22:21:52]

How feasible to add unit tests for this and below to CompositorMutableStateTest?

[weiliangc, 2017/03/28 20:21:28]

I assume this is more along the line of the CompositorMutableStateTest would
continue to pass. This test looks like it's testing setOpacity and setTransform
functions:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/graph...

[wkorman, 2017/03/28 23:32:46]

Oh cool, I looked but missed that somehow, thanks.

+                                                    opacity);
   m_mutation->setOpacity(opacity);
 }
 
@@ -37,11 +35,8 @@ const SkMatrix44& CompositorMutableState::transform() const {
 void CompositorMutableState::setTransform(const SkMatrix44& matrix) {
   if (!m_mainLayer)
     return;
-  m_mainLayer->layer_tree_impl()
-      ->property_trees()
-      ->transform_tree.OnTransformAnimated(gfx::Transform(matrix),
-                                           m_mainLayer->transform_tree_index(),
-                                           m_mainLayer->layer_tree_impl());
+  m_mainLayer->layer_tree_impl()->SetTransformMutated(m_mainLayer->element_id(),
+                                                      gfx::Transform(matrix));
   m_mutation->setTransform(matrix);
 }