cc: LayerTreeHostImpl uses element id to tick animations

third_party/WebKit/Source/platform/graphics/CompositorMutableState.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/graphics/CompositorMutableState.h"
 
 #include "cc/layers/layer_impl.h"
 #include "cc/trees/layer_tree_impl.h"
 #include "platform/graphics/CompositorMutation.h"
 
 namespace blink {
 CompositorMutableState::CompositorMutableState(CompositorMutation* mutation,
                                                cc::LayerImpl* main,
                                                cc::LayerImpl* scroll)
     : m_mutation(mutation), m_mainLayer(main), m_scrollLayer(scroll) {}
 
 CompositorMutableState::~CompositorMutableState() {}
 
 double CompositorMutableState::opacity() const {
   return m_mainLayer->Opacity();
 }
 
 void CompositorMutableState::setOpacity(double opacity) {
   if (!m_mainLayer)
     return;
-  m_mainLayer->layer_tree_impl()
-      ->property_trees()
-      ->effect_tree.OnOpacityAnimated(opacity, m_mainLayer->effect_tree_index(),
-                                      m_mainLayer->layer_tree_impl());
+  m_mainLayer->layer_tree_impl()->SetOpacityMutated(m_mainLayer->element_id(),

[wkorman, 2017/03/27 22:21:52]

How feasible to add unit tests for this and below to CompositorMutableStateTest?

[weiliangc, 2017/03/28 20:21:28]

I assume this is more along the line of the CompositorMutableStateTest would
continue to pass. This test looks like it's testing setOpacity and setTransform
functions:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/graph...

[wkorman, 2017/03/28 23:32:46]

Oh cool, I looked but missed that somehow, thanks.

+                                                    opacity);
   m_mutation->setOpacity(opacity);
 }
 
 const SkMatrix44& CompositorMutableState::transform() const {
   return m_mainLayer ? m_mainLayer->Transform().matrix() : SkMatrix44::I();
 }
 
 void CompositorMutableState::setTransform(const SkMatrix44& matrix) {
   if (!m_mainLayer)
     return;
-  m_mainLayer->layer_tree_impl()
-      ->property_trees()
-      ->transform_tree.OnTransformAnimated(gfx::Transform(matrix),
-                                           m_mainLayer->transform_tree_index(),
-                                           m_mainLayer->layer_tree_impl());
+  m_mainLayer->layer_tree_impl()->SetTransformMutated(m_mainLayer->element_id(),
+                                                      gfx::Transform(matrix));
   m_mutation->setTransform(matrix);
 }
 
 float CompositorMutableState::scrollLeft() const {
   return m_scrollLayer ? m_scrollLayer->CurrentScrollOffset().x() : 0.0;
 }
 
 void CompositorMutableState::setScrollLeft(float scrollLeft) {
   if (!m_scrollLayer)
     return;
@@ skipping 19 matching lines @@
   offset.set_y(scrollTop);
   m_scrollLayer->layer_tree_impl()
       ->property_trees()
       ->scroll_tree.OnScrollOffsetAnimated(
           m_scrollLayer->id(), m_scrollLayer->scroll_tree_index(), offset,
           m_scrollLayer->layer_tree_impl());
   m_mutation->setScrollTop(scrollTop);
 }
 
 }  // namespace blink